[Solved] Questions about OJS 3.0.2

asmecher · October 14, 2017, 12:01am

Thanks, that’s helpful. I’ve filed this for attention at Resolve JS console warning · Issue #2863 · pkp/pkp-lib · GitHub.

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 22, 2017, 11:43pm

I am having a problem I haven’t notice before.
When setting a reviewer to judge a paper, the deadline is completly wrong, even when its set correctly: Look:

Somehow, i think its related to the time settings on the config.php, but i have no clue how to fix it.
My config.php is this:

; Short and long date formats
date_format_trunc = “%d-%m”
date_format_short = “%d-%m-%Y”
date_format_long = “%B %e, %Y”
datetime_format_short = “%d-%m-%Y %I:%M %p”
datetime_format_long = “%B %e, %Y - %I:%M %p”
time_format = “%I:%M %p”

I don’t think the problem is in the server clock since the time is correctly showed on everywhere else:

Any ideas?

asmecher · October 24, 2017, 5:26pm

Hi @Hugo_Melo,

I believe this is already filed at Changing date formats in config.inc.php can lead to misparsed dates · Issue #2689 · pkp/pkp-lib · GitHub. I’ll link to your description from the bug entry.

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 24, 2017, 6:41pm

According to the issue, if i turn my config.php back to original the problem will not happen?

asmecher · October 24, 2017, 7:13pm

Hi @Hugo_Melo,

You can try that and see if it changes the behavior. However, I’ve just tried with OJS 3.1.0 and your date format setting and wasn’t able to reproduce the problem. The most helpful thing would be to…

confirm whether restoring the date setting solves the problem, and
confirm whether you’re able to reproduce this behavior in OJS 3.1.0, and
confirm whether the patch at pkp/pkp-lib#2689 Bug fix for altFormat use by defstat · Pull Request #2775 · pkp/pkp-lib · GitHub fixes the issue, either on 3.0.2 or on 3.1.0.

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 25, 2017, 2:41pm

Okay. Getting the time in config.php back to original turned off the error.

I will now update do 3.1 and change time to Brazilian again and see if the error is back, and report here for you.
Thanks for the patience.

asmecher · October 27, 2017, 3:40pm

Hi @Hugo_Melo,

One of our developers has put together a patch for the Javascript issue you described earlier. Could you test this change and report back whether or not it corrects the issue?

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 27, 2017, 5:04pm

Alright, I am about to try this, but i need more info.
For example, in what file should i put this code? At what position?
I am already at OJS 3.1, should I try this piece of code? I am waiting for receiving any article for evaluation to test if the error still in ojs 3.1.

asmecher · October 27, 2017, 9:27pm

Hi @Hugo_Melo,

The best way to apply the change is using the standard “patch” tool. You can read more about patch files e.g. here: What is the format of a patch file? - Stack Overflow

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 27, 2017, 11:06pm

Man, i’ve read it several times, but I think it is too much for my experties.
I couldn’t figure out how to “patch” that piece of code.
I will test the same error in 3.1 to see if it continues though, and let you know.

asmecher · October 27, 2017, 11:29pm

Hi @Hugo_Melo,

In brief, edit lib/pkp/js/classes/TinyMCEHelper.js; find the lines that the patch describes starting with a - and remove them; and add in their place the lines the patch describes with a +. (Omit the - and +, of course.)

Note that you’ll nave to turn off minification in your config.inc.php for these files to be used instead, and you’ll need to reload in your browser.

Regards,
Alec Smecher
Public Knowledge Project Team

Hugo_Melo · October 28, 2017, 12:59pm

OKay. I am here to show you that the error persists in 3.1, and it is even worse, the date is now empty:

I will try to insert the code and let you guys know about it.

However, i am having a more annoying trouble now. The email models i have made to notify authors, isn’t showing anymore. Tried to delete and create it again, but still not showing, and interesting it always create as a Signture Manager, what didn’t happen in 3.0.2:

This is what I am getting:

When i turn the notifications on, the page is not even loading:

Strict Standards: Declaration of DRIVERDAO::setOAI() should be compatible with PKPOAIDAO::setOAI($oai) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php on line 19

Strict Standards: Declaration of PKPWorkflowHandler::initialize() should be compatible with PKPHandler::initialize($request) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/pages/workflow/PKPWorkflowHandler.inc.php on line 506

Warning: Cannot modify header information - headers already sent by (output started at /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php:19) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 855

Warning: Cannot modify header information - headers already sent by (output started at /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php:19) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 856