PHP Fatal error: Uncaught Error: Call to a member function getSubmissionId() on null...pkp/classes/submission/SubmissionFileDAO.inc.php:456

seisense · January 11, 2021, 7:36pm

Hi,
OJS: 3.2.1.2
PHP 7.4

I found the following error in my PHP error log and it has appeared 3 times in the error log so far. Please help me to fix the error.

[11-Jan-2021 07:43:00 America/New_York] PHP Fatal error:  Uncaught Error: Call to a member function getSubmissionId() on null in /home/seisense/journal.seisense.com/lib/pkp/classes/submission/SubmissionFileDAO.inc.php:456
Stack trace:
#0 /home/seisense/journal.seisense.com/lib/pkp/controllers/wizard/fileUpload/PKPFileUploadWizardHandler.inc.php(422): SubmissionFileDAO->assignRevisionToReviewRound(2593, 2, NULL)
#1 /home/seisense/journal.seisense.com/controllers/wizard/fileUpload/FileUploadWizardHandler.inc.php(31): PKPFileUploadWizardHandler->_attachEntities(Object(SubmissionFile))
#2 /home/seisense/journal.seisense.com/lib/pkp/controllers/wizard/fileUpload/PKPFileUploadWizardHandler.inc.php(375): FileUploadWizardHandler->_attachEntities(Object(SubmissionFile))
#3 /home/seisense/journal.seisense.com/lib/pkp/classes/core/PKPRouter.inc.php(391): PKPFileUploadWizardHandler->uploadFile(Array, Object(Request))
#4 /home/seisense/journal.seisense.com/lib/pkp/classes/core/PKPComponentRouter.inc.php(257): PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(Request),  in /home/seisense/journal.seisense.com/lib/pkp/classes/submission/SubmissionFileDAO.inc.php on line 456

Thanks

NateWr · January 12, 2021, 11:59am

It looks like this error is related to a review round being expected but not passed:

github.com

pkp/pkp-lib/blob/stable-3_2_1/classes/submission/SubmissionFileDAO.inc.php#L456


	/**
	 * Assign file to a review round.
	 * @param $fileId int The file to be assigned.
	 * @param $revision int The revision of the file to be assigned.
	 * @param $reviewRound ReviewRound
	 */
	function assignRevisionToReviewRound($fileId, $revision, $reviewRound) {
		if (!is_numeric($fileId) || !is_numeric($revision)) fatalError('Invalid file!');
		// Avoid duplication errors -- clear out any existing entries
		$this->deleteReviewRoundAssignment($reviewRound->getSubmissionId(), $reviewRound->getStageId(), $fileId, $revision);
		return $this->update(
			'INSERT INTO review_round_files
				(submission_id, review_round_id, stage_id, file_id, revision)
			VALUES (?, ?, ?, ?, ?)',
			array(
				(int)$reviewRound->getSubmissionId(),
				(int)$reviewRound->getId(),
				(int)$reviewRound->getStageId(),
				(int)$fileId,

A quick scan suggests that this might be happening when an editor decision is made (eg - request revisions) or when a revision is uploaded. You could try testing file handling around those actions to see if you can reproduce it. If you can find a reproducible steps we can investigate it further.

seisense · January 12, 2021, 5:11pm

Hi @NateWr ,
You were right. I was able to produce this error following your lead.
It is happening when the author tries to upload the file in the revisions tab after the decision is already made on the submission.
Thanks and regards

NateWr · January 13, 2021, 10:02am

I was unable to reproduce this using our stable-3_2_1 branch. I tried the following steps.

Find a submission in review.
Accept the submission and send it to copyediting.
Login as author.
Go to review stage as author.
Upload a revision.

Can you reproduce this on a brand new submission? I’m wondering if maybe there’s some additional condition here that we haven’t detected. The other possibility is that this has been fixed in our stable-3_2_1 branch since 3.2.1-2 was released.