OJS review form settings get deleted/overwritten on upgrade from 3.2 to 3.3

Software Support
,
1

Describe the issue or problem
Review form settings are overwritten when upgrading form OJS 3.2.1-3 to 3.3.0.17 - the respective DB table (review_form_element_settings) gets completely gutted (possibleResponses are more or less completely empty now) except for the questions themselves, see screenshots below. There seems to be absolutely no one else with this problem on the forum and no indication in the release notes as to when the review forms were changed/overhauled. Can anyone from PKP advise?

Steps I took leading up to the issue
We upgraded using the upgrade script from 3.2.1-3 to 3.3.0-17

What application are you using?
OJS 3.3.0-17

Additional information

grafik
grafik1439Ɨ157 52.3 KB

grafik
grafik956Ɨ354 69.1 KB

2

I confirm a similar issue with reviewer forms. And this is definitely a problem caused by the update process.
In our case, there was a migration from 3.1.2-4 to 3.3.0-17, after that we have the same mess in all forms. As a workaround, we copied the broken forms and created new ones based on them. However, developers need to figure this out so that future migrations donā€™t cause even more serious problems.

3

Thank you for confirming this - unfortunately the workaround is not really feasible for us since all the old review form replies and the review forms currently used in peer review will get destroyed by the upgrade script as well. Weā€™re hoping this can be addressed in some way so nothing gets lost.

4

Sure, I understand, the situation is ridiculous. This is the most serious problem in our migration, everything else has been resolved. Well, waiting for PKP team responseā€¦

5

Hi all ā€“ if someone can send me (privately) a pre-upgrade dump form version 3.2, I can look into it. Also, please confirm if there were error messages or warnings during the upgrade process.

Thanks,
Alec Smecher
Public Knowledge Project Team

7

We tried several approaches, and finally ended up migrating from 3.1 to 3.3 directly. Thatā€™s why I donā€™t have 3.2 dump, only 3.1.2-4.
As for problems we had some (DB errors) during the upgrade, but they concerned citation table, indexes, etc. After solving this issue (TRUNCATE TABLE citations + ā€˜parseCitations.php allā€™ after upgrade), we had no errors either when upgrading the database or when executing other scripts/xml.
After completing ā€˜upgrade.php upgradeā€™ successfully, we had problems in the web server part (frontend and backend), but the data/files did not raise any issues. The only loss is precisely the forms of reviews.
So I guess this is not a ā€œ3.2 problemā€, but some kind of global problem with 3.3 migration.

8

We may have found a workaround that preserves the review form settings but it requires an intermediate step between 3.2.1-3 to 3.3.0-17. When we took the system from 3.2.1-3 to 3.3.0-3 and only then to 3.3.0-17 the review form settings remained as they are. But we just found out the image links broke as discussed in Article images link broken CAUSED BY UPDATING OJS 3.3.0.8. Itā€™s always one step forward, two steps back :frowning:

9

Hi all,

Thanks to @ojs_univie for the database dump!

I was able to reproduce the issue and solve it. Itā€™s filed here:

The fix will be released in OJS/OMP 3.3.0-18 and 3.4.0-6. Until those are released, you can apply the following patches before upgrading:

@ojs_univie or @rkhalikov, your confirmation that this resolves the problem would be appreciated if possible!

Regards,
Alec Smecher
Public Knowledge Project Team

10

This topic was automatically closed after 10 days. New replies are no longer allowed.

11

Hi all,

Iā€™ve had confirmation that the patches listed above resolve the problem. If youā€™re using OJS or OMP 3.3.0-17 or older, or 3.4.0-6 or older, and you use review forms, I recommend applying the patch before upgrading.

Regards,
Alec Smecher
Public Knowledge Project Team

12

Hi @asmecher,

May be itā€™s me but I think this change introduced a regression in 3.3.0-18.

Upgrade from 3.2 to 3.3 works like a charm till 3.3.0-17 (except for the review forms) but when I try to upgrade to -18, the upgrade script shows the following error:

2024-09-18 08:41:16 [migration: OJSv3_3_0UpgradeMigration]                                                                                                                                    
Failed to migrate the settings entity "object_for_review_settings"                                                                                                                            
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'setting_name' in 'field list' in /var/www/html/lib/pkp/lib/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.p
hp:80                                                                                                                                                                                         
Stack trace:                                                                                                                                                                                  
#0 /var/www/html/lib/pkp/lib/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php(80): PDO->prepare()                                                                              
#1 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(331): Doctrine\DBAL\Driver\PDOConnection->prepare()                                              
#2 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(664): Illuminate\Database\Connection->Illuminate\Database\{closure}()                            
#3 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(631): Illuminate\Database\Connection->runQueryCallback()
#4 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(339): Illuminate\Database\Connection->run()
#5 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2270): Illuminate\Database\Connection->select()
#6 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2258): Illuminate\Database\Query\Builder->runSelect()
#7 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2753): Illuminate\Database\Query\Builder->Illuminate\Database\Query\{closure}()
#8 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2259): Illuminate\Database\Query\Builder->onceWithColumns()
#9 /var/www/html/classes/migration/upgrade/OJSv3_3_0UpgradeMigration.inc.php(114): Illuminate\Database\Query\Builder->get()
#10 /var/www/html/classes/migration/upgrade/OJSv3_3_0UpgradeMigration.inc.php(37): OJSv3_3_0UpgradeMigration->_settingsAsJSON()
#11 /var/www/html/lib/pkp/classes/install/Installer.inc.php(406): OJSv3_3_0UpgradeMigration->up()
#12 /var/www/html/lib/pkp/classes/install/Installer.inc.php(252): Installer->executeAction()
#13 /var/www/html/lib/pkp/classes/install/Installer.inc.php(175): Installer->executeInstaller() 
#14 /var/www/html/lib/pkp/classes/cliTool/UpgradeTool.inc.php(89): Installer->execute()
#15 /var/www/html/lib/pkp/classes/cliTool/UpgradeTool.inc.php(65): UpgradeTool->upgrade()
#16 /var/www/html/tools/upgrade.php(22): UpgradeTool->execute()
#17 {main}

Process exits with the ā€œSuccessfullyā€ message, and the journal seams functional (testing in detail right now), but the error generates a kind of disquiet feeling.

Itā€™s safe to upgrade to -18 even this error?

I tested jumping directly from stable-3.2 to 3.3.0-19 and then the upgrade breaks.

Reporting both issues in githHub to keep the track:

Cheers,
m.

13

Hi @marc,

I see youā€™ve filed this in Github:

Adding the link to this thread.

Regards,
Alec Smecher
Public Knowledge Project Team

1 Like
14

Yep, but I though they were different issues and I didnā€™t want to mix them in this thread.
But itā€™s also a good idea to compile all recent upgrade issues here, so fellows can find them clear an sorted.

For those that like a TL;DR; version of the thread:

There is an issue in OJS upgrade till version 3.3.0-17 that mixes the reviewersā€™ forms radio and dropdown answers.
A fix was introduced in -18 but donā€™t full fix the problem (see #9953). After this, an additional bug related with subr calls happen in version -19 (see #10445. Thanks Alec for the fast patch!) so recommendation for upgrades is apply the patches before upgrade or wait till version -20 is released.

Please, correct me if something is wrong.