Article images link broken CAUSED BY UPDATING OJS 3.3.0.8

Carlos_Alberto_Rivad · April 4, 2022, 4:42pm

hello community I have a problem since I update my site to version ojs 3.3.0.8 the problem occured in my journal articles. my journals article each one has galleys like HTML and XML, in the HTML format I upload to the system the index.html and the dependent files as the image below

as you see in the image each file name has admin this word or kind of configuration was caused by the new version ojs 3.3.0.8 automatically each dependent file has admin name at the begining causing that when you open the html galley the images are broken because the file doesnt find those images files as you see in my example

https://revista.uisrael.edu.ec/index.php/rcui/article/view/496/513

So i am looking for a solution hope you can help me to get rid of this word “admin” of each dependent image file of my articles because this is causing images broken didnt find SO IS THERE A WAY TO SOLVE THIS IN THE DATABASE OR ANOTHER WAY YOU CAN SOLVE IT THANKS

asmecher · April 7, 2022, 6:38pm

Hi @Carlos_Alberto_Rivad,

What version of OJS did you upgrade from?

Regards,
Alec Smecher
Public Knowledge Project Team

Carlos_Alberto_Rivad · April 7, 2022, 10:15pm

I upgrade from ojs 3.2.1.4

Carlos_Alberto_Rivad · April 8, 2022, 3:18pm

@asmecher Hi is there any solution for this problem

asmecher · April 8, 2022, 10:14pm

Hi @Carlos_Alberto_Rivad,

Did you upgrade directly from OJS 3.2.1-4 to 3.3.0-8, or did you upgrade to intermediate versions? The problem you’re describing is this one:

github.com/pkp/pkp-lib

Links to dependent files referenced in HTML/JATS XML galleys are broken

opened 11:51AM - 26 Feb 21 UTC

closed 06:46PM - 05 Mar 21 UTC

Vitaliy-1

**Describe the bug** As part of submission files refactoring `originalFileName`… property was dropped and is only stored in the `event_log_settings`. `name` property is used instead. This causes incorrect links to the dependent files referenced in HTML and XML galleys/submission files added before the upgrade as now the code, e.g., in HTML galley plugin, tries to link files using regex and relying on the `name` property: https://github.com/pkp/ojs/blob/3fecde2c940371d88838e983d0395b3c56983cb3/plugins/generic/htmlArticleGalley/HtmlArticleGalleyPlugin.inc.php#L157 **To Reproduce** Consider situations when a user adds a new HTML galley in OJS 3.2.1 and attaches images as dependent files with original file names, like `fig1.jpg`, `fig2.jpg`, etc... In HTML galleys those images also are referenced by original filename: `<img src="fig1.jpg">`. During upload OJS autosuggests to name those files in the format: `[username], filename`. After upgrade to 3.3.0 those links are not more valid. Relevant for HTML Article Galley Plugin, Lens Viewer Plugin, JATS Parser Plugin. Didn't check Texture but suspect it's also the case. **What application are you using?** OJS 3.3.0 **Additional information** Related issues: https://github.com/pkp/pkp-lib/issues/4957 https://github.com/pkp/pkp-lib/issues/6288

…but it was fixed in OJS 3.3.0-4 so shouldn’t be affecting you with an upgrade to 3.3.0-8.

Regards,
Alec Smecher
Public Knowledge Project Team

Carlos_Alberto_Rivad · April 8, 2022, 10:59pm

hi @asmecher The updates were done in a staggered manner. From 3.2.1-4, we continued with the next one and so on until we reached 3.3.0-8.

but as you see it is affecting

asmecher · April 8, 2022, 11:39pm

Hi @Carlos_Alberto_Rivad,

That’s a lot of extra work and not a process I’d recommend! You should be able to upload directly from 3.2.1-4 to the latest 3.3.0-x, and you’ll find this problem goes away in the process.

Regards,
Alec Smecher
Public Knowledge Project Team

Elena_Najera · September 23, 2024, 4:57pm

Hello @asmecher

The same thing happens for OJS 3.4.x I have posted a new discussion here. Broken images in XML after updating

I am very grateful for any comments. Regards,