Null notifications, what are those supposed to be?

ctgraham · February 7, 2022, 5:27pm

I think 369098754 and 369098756 are from the PKP PN plugin, specifically NOTIFICATION_TYPE_PLUGIN_BASE ( 0x6000001)

pkp/pkp-lib/blob/097e08e6d06698999eaa270e6e1ae456e1d5a22c/classes/notification/PKPNotification.inc.php#L40

      
        
            define('NOTIFICATION_TYPE_INFORMATION',				0x0000005);
            define('NOTIFICATION_TYPE_HELP',				0x0000006);
            define('NOTIFICATION_TYPE_FORM_ERROR',				0x0000007);
            define('NOTIFICATION_TYPE_NEW_ANNOUNCEMENT',			0x0000008);
            
            
define('NOTIFICATION_TYPE_LOCALE_INSTALLED',			0x4000001);
            
            
define('NOTIFICATION_TYPE_PLUGIN_ENABLED',			0x5000001);
            define('NOTIFICATION_TYPE_PLUGIN_DISABLED',			0x5000002);
            
            
define('NOTIFICATION_TYPE_PLUGIN_BASE',				0x6000001);
            
            
class PKPNotification extends DataObject {
            	/**
            	 * Constructor.
            	 */
            	function PKPNotification() {
            		parent::DataObject();
            	}
            
            
	/**

plus (!?!?) 0x10000000 as PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE;
and plus 0x0000001 as PLN_PLUGIN_NOTIFICATION_TYPE_TERMS_UPDATED:

github.com

pkp/pln/blob/d47c4808528ce073ce5a6f40f53f307ae6092df4/PLNPlugin.inc.php#L71-L72

      
        
            define('PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE',	Notification::NOTIFICATION_TYPE_PLUGIN_BASE + 0x10000000);
            define('PLN_PLUGIN_NOTIFICATION_TYPE_TERMS_UPDATED',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000001);

or plus 0x0000003 as PLN_PLUGIN_NOTIFICATION_TYPE_HTTP_ERROR:

github.com

pkp/pln/blob/d47c4808528ce073ce5a6f40f53f307ae6092df4/PLNPlugin.inc.php#L74

      
        
            define('PLN_PLUGIN_DEPOSIT_STATUS_LOCKSS_AGREEMENT',	0x80); // was UPDATE
            
            
define('PLN_PLUGIN_DEPOSIT_STATUS_UPDATE',				0x100);
            
            
define('PLN_PLUGIN_DEPOSIT_OBJECT_SUBMISSION', 'Submission');
            define('PLN_PLUGIN_DEPOSIT_OBJECT_ISSUE', 'Issue');
            
            
define('PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE',	Notification::NOTIFICATION_TYPE_PLUGIN_BASE + 0x10000000);
            define('PLN_PLUGIN_NOTIFICATION_TYPE_TERMS_UPDATED',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000001);
            define('PLN_PLUGIN_NOTIFICATION_TYPE_ISSN_MISSING',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000002);
            define('PLN_PLUGIN_NOTIFICATION_TYPE_HTTP_ERROR',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000003);
            // define('PLN_PLUGIN_NOTIFICATION_TYPE_CURL_MISSING',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000004); DEPRECATED
            define('PLN_PLUGIN_NOTIFICATION_TYPE_ZIP_MISSING',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000005);
            define('PLN_PLUGIN_NOTIFICATION_TYPE_TAR_MISSING',	PLN_PLUGIN_NOTIFICATION_TYPE_PLUGIN_BASE + 0x0000006);
            
            
class PLNPlugin extends GenericPlugin {
            	/**
            	 * @copydoc LazyLoadPlugin::register()
            	 */
            	public function register($category, $path, $mainContextId = null) {
            		if (!parent::register($category, $path, $mainContextId)) return false;

This crime against HEX is still present in master.