Hi all,
We are testing the upgrade from OJS 2.4.8-1 to OJS 3. Our journals have HTML galleys with associated images and css.
When we upgrade to OJS 3.1.2-4, the HTLM galley and embedded images display correctly when we activate the “HTML Article Galley” plugin.
If we upgrade to 3.2.0-1 or 3.2.0 from 2.4.8-1 or 3.1.2.4 the HTLM galley is displayed, but the images and css are not loaded.
The image URL (…/article/download/46/138/613) in OJS 3.1.2-4 the image is downloaded
But in 3.2.0 or 3.2.0-1 it shows the message “404 Not Found”
Thank you very much.
Regards
Hi @juanf.csic,
How are the images etc. referred to in the HTML files?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi Alec,
The images are uploaded as HTML dependent files (see screenshot).
The name of the image (example: loquens041_f02_G.jpg) is replaced correctly by the URL that references the file (http://journaltestojs3.com/index.php/loquens/article/download/46/138/611). (See screenshot)
But that URL does not download the image and displays a “404 Not Found”.
I have removed the images and reloaded them again, but continue without loading the images.
However in the upgrade to version 3.1.2-4, the HTML generates exactly the same URL in the replacement, but the URL downloads the image (see screenshot)
Thank you very much.
Regards
Hi @juanf.csic,
Thanks, that’s helpful – would you be able to try a new submission in OJS 3.2.0-x to see if it suffers the same problem, i.e. to establish whether the problem is in the upgrade code or in the HTML publishing code?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi Alec,
I have made a new submission as journal editor, and I have published it in one of the existing issues, and the images do not load…
The image name is replaced by the URL that references the image file, but the URL does not download the image and shows “404 Not Found”.
The issue I think is not related to the upgrade…
Thank you very much.
Regards
Hi @juanf.csic,
Could you PM me with a database dump and a copy of your files directory? I’d like to take a look at the database in more detail.
Regards,
Alec Smecher
Public Knowledge Project Team
Hi Alec,
I’ve tried the change, and it doesn’t work for me…
Regards
Hi @juanf.csic,
Does anything appear in your PHP error log?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi Alec,
This appears in php-log file:
[01-Apr-2020 23:39:51 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:51 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:51 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:51 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:51 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:51 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:51 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:53 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:53 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:53 Europe/Berlin] PHP Warning: Use of undefined constant SUBMISSION_FILE_DEPENDENT - assumed ‘SUBMISSION_FILE_DEPENDENT’ (this will throw an Error in a future version of PHP) in E:\web\revistascsic\loquens3201\pages\article\ArticleHandler.inc.php on line 384
[01-Apr-2020 23:39:53 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:53 Europe/Berlin] ojs2: 404 Not Found
[01-Apr-2020 23:39:53 Europe/Berlin] ojs2: 404 Not Found
Could you try my database, in case the problem is ours?
Regards
Hi @juanf.csic,
This change, applied in the lib/pkp directory, should solve it:
https://github.com/pkp/pkp-lib/commit/5d69af5863404656f8f8d435e3de323005927946
Regards,
Alec Smecher
Public Knowledge Project Team
Hi Alec,
Yes, now it works.
Thank you so much!!!
Regards
Hi @juanf.csic,
Great – we’ll get that released in the OJS 3.2.0-2 build, within the next week (we hope); in the meantime that patch should do the trick.
Regards,
Alec Smecher
Public Knowledge Project Team
I have 37 journals to upgrade, each with an OJS installation. Before I start, I needed to make sure that version 3.2 worked for me. If not, I would have upgraded to 3.1.2-4 which worked fine for me.
The pkp team is doing a fantastic job.
Thank you so much again, Alec
Regards
1 Like
Hi everybody,
I have the same problem.
I uploaded the html file and .jpg files. and also used the pach and changed the codes in SubmissionDAO.inc.php. Then, I removed the HTML galley and associated figures and uploaded again.
Nothing changed: https://ccbjournal.info/index.php/CCB/article/view/14/48
I checked the Galley html file. I saw that the address for figures are not changed (they are the same as original addresses) and I saw these errors in error_log: “ojs2: 404 Not Found”
Please do not consider my last comment. It is resolved now. In OJS 3.2.0-1 I applied both changes mentioned by @asmecher
Thank you @asmecher for your help.
1 Like