User home link wrong

UBWolf · August 8, 2016, 6:17am

Hi there,

after upgrading to version 2.4.8.1 we found some odd behaviour: even if the user has more than one journal, the button “user home” links only to this specific journal, not to the list:
adress/index.php/journal/user instead of adress/index.php/index/user
The funny thing ist: We have three ojs installations, but in one of them the link is correct, in the other ones it is not. I have already checkt the navbar.tpl, but it is the same in every installations. Are there any other places I could check?

Kind regards
Daniela

cjuergen · August 8, 2016, 9:05am

Hi @UBWolf,

do you have any customizations? We upgraded a test instance from 2.4.8 to 2.4.8.1 and the links are ok.

Hope this helps
Claudia Jürgen

UBWolf · August 8, 2016, 9:21am

Hi @cjuergen,

thank you for your answer. We have some plugins and stylesheets, but nothing that changes the links. And yes, I refer to the link in the main menu. It always lead to the journal user home, not the general user home.

Kind regards
Daniela

ctgraham · August 8, 2016, 1:21pm

A recent change in 2.4.8 was the addition of code specifically to detect if the user was in a single journal context and, if so, limit the User Home link to that journal:

github.com

pkp/ojs/blob/ojs-stable-2_4_8/templates/common/navbar.tpl#L17


*
* Navigation Bar
*
*}
<div id="navbar">
	<ul class="menu">
		<li id="home"><a href="{url page="index"}">{translate key="navigation.home"}</a></li>
		<li id="about"><a href="{url page="about"}">{translate key="navigation.about"}</a></li>

		{if $isUserLoggedIn}
			<li id="userHome"><a href="{if $hasOtherJournals}{url journal="index" page="user"}{else}{url page="user"}{/if}">{translate key="navigation.userHome"}</a></li>
		{else}
			<li id="login"><a href="{url page="login"}">{translate key="navigation.login"}</a></li>
			{if !$hideRegisterLink}
				<li id="register"><a href="{url page="user" op="register"}">{translate key="navigation.register"}</a></li>
			{/if}
		{/if}{* $isUserLoggedIn *}

		{if $siteCategoriesEnabled}
			<li id="categories"><a href="{url journal="index" page="search" op="categories"}">{translate key="navigation.categories"}</a></li>
		{/if}{* $categoriesEnabled *}

Currently, this variable is set based on whether or not there is a site level redirect.

github.com

pkp/ojs/blob/ojs-stable-2_4_8/classes/template/TemplateManager.inc.php#L132-L134


			if (!$site->getRedirect()) {
				$this->assign('hasOtherJournals', true);
			}

That might cause some interesting edge cases, one of which you might be hitting.

What is this setting for the install that works vs. the installs that don’t?

UBWolf · August 8, 2016, 1:36pm

Thank you for your help!
Unfortunately the code you posted is the same with every install. Are there any other settings I could check?
The website settings are also the same.

Kind regards
Daniela

ctgraham · August 8, 2016, 1:38pm

Do you mean there is no Journal Redirect in Site Settings for any install, or that there is a Journal Redirect in Site Settings for all installs?

UBWolf · August 8, 2016, 1:43pm

Ah, now I understand. You are right, the installs with the problem have a redirect in the setings, the one without doesn’t have it. I changed that and the problem was there as well. So, now we know what causes the problem Unfortunately I can’t change the redirect, so I need another solution to fix this.

But thank you so much, that helps a lot!

Kind regards
Daniela

ctgraham · August 8, 2016, 1:47pm

So, to clarify: you have a multi-journal install which redirects to a single journal, but you want the users to access other journals under that site when they go to the user home?

If you use-case is common, we may want to re-evaluate the use of the redirect setting for detecting a multi-journal install.

In the meantime, you may want to revert the change of this patch:

UBWolf · August 8, 2016, 1:54pm

Yes, that’s exactly what we want.

Thank you!