I made some tests with OJS 3.4 rc3 and have some feebacks/questions.
Take in mind that I mainly use 3.1.X version so my comment can be useless
- If we are login as an author and this author has no submission, if we are on the front website of OJS, and we select Dashboard in the menu in upper right, we go to the Profile page, it’s disappointing : I’d prefer to go to new submission I think.
Submission form:
- I setup only 3 Components for an Article (in management/settings/workflow#submission/components) but when I submit a new submission, all default types are proposed ?
In the best, if there is only 2 or 3 Components Types, It should be selective directly without a popup. - Sorry for that, but I find that ergonomie for multilinguisme is not easy to use. Maybe some modifications could be made on submission metadata form especially in multi language support. the form is by default in submission language : label of input are “Title” etc. and then when you clic on other language, label is English for all input. I think that if we have multilingual support for submissions, label could be, even for default language, “Title ($name of language)” (true for all input)
In same form, in languages other than submission language, input like Title are required (red star), but if you don’t fill it, there is no error.
Maybe we could remove red stars
Always in submission form, with french as submission language and english for UI, in the contributor list, the english name of the author (I imagine if he registered in english) is shown. If you add, a contributor, it’s the french version of the name of the new contributor that is shown. But at the end of the submission, when validating all inputs, there is an error as primary author has not fill french version (submission language) of his name, so author has to edit his contributor role to add french name. I think, in this case, for the current author, name should be “Fill french version of name” or something like that.
I think it’s all for submission form.
As a Journal Manager, when I assign an editor and select template mail “Assign Editor”, which contains {$recipientName}, the sent email has the tag {$recipientName} replaced but not in the created discussion.
When you send submission to review, in the modal, it is written that an email will be sent to authors, so author and co authors receive an email. But in the activity log, there is only one log for the email sent to the principal author, not co authors. contrary to the email sent when submission is validated, which author and co authors email are logged (detail but for consistency)
In the email template there is {$reviewTypeDescription} which is remplaced by the journal default review mode, but Editor can choose a different review mode when he invites reviewers, so it could be confusing for authors.
as an author, when submission begin the review step, I can click on “Upload file” in Revisions, but I get a message “you’re not allowed to add or edit these files” : logic, but maybe it’s better not to show the button (or disable).
“as an author, when I create a discussion, I can uncheck myself”, is it necessary ? I think author should be checked by default and checkbox should be disabled.
“As an author, I can access to Publication tab of my submission and input are not disabled, so I can update content but I can’t send it because Save button is disabled” : I think all fields should be disabled and add a text with something like “If you want change metadata, open a new discussion. Thank you”
I try to follow unsubscribe link in a discussion email, “http://localhost:8000/index.php/publicknowledge/notification/unsubscribe?validate=&id=263” it goes to error 404 .
UI evolution : in the list of reviewers (when selecting a new reviewer), I think that the email address of the reviewer could be listed under the reviewer name, as it could help to detect old email addresses.
A regrettable thing in the add reviewer modal is that is not the new select email form with the possibility of select language of the template. I think is maybe the main place that this new form should be because, often in our case, editor want to select the language in function of the reviewer.
As a reviewer, I think I’d really prefer the new upload file form as in the submission form : just simply drag & drop file without open a modal with 3 steps ; upload file, change name and Finish step!
For our journals, it’s very difficult to find (good) reviewers, so make easier the reviewers job and the communication between editors and reviewers ( like add the ability to select email template language) should be very appreciate.
a really good thing is the ability to inform reviewers when taking a decision, but only reviewer of the last round are shown, I think reviewers of all rounds who have responded should be shown.
One minor thing, when you “Cancel copyediting” after accept submission, the status go back in Review step but the status of the submission is still “submission accepted”. (in the activity log : “##{$editorName} has sent this submission back from the copyediting stage.##” )
As an editor, I send to review a new submission and, then cancel the round review, so submission go back in Submission step. I resend to review and then, want to show the Activity Log : get Error 500.
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33640 [200]: GET /index.php/publicknowledge/$$$call$$$/information-center/submission-information-center/view-information-center?submissionId=11&=1682582418976
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33640 Closing
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33642 Accepted
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33642 [200]: GET /index.php/publicknowledge/$$$call$$$/information-center/submission-information-center/view-history?submissionId=11&=1682582418977
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33642 Closing
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33648 Accepted
[Thu Apr 27 10:00:58 2023] Missing locale key “{$editorName} cancelled the review round.” for the locale “en”
[Thu Apr 27 10:00:58 2023] PHP Fatal error: Uncaught Error: Call to a member function getStageId() on null in /tmp/ojs/lib/pkp/classes/submissionFile/Repository.php:704
Stack trace:
#0 /tmp/ojs/lib/pkp/controllers/grid/eventLog/EventLogGridRow.php(91): PKP\submissionFile\Repository->getWorkflowStageId()
#1 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1220): PKP\controllers\grid\eventLog\EventLogGridRow->initialize()
#2 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1130): PKP\controllers\grid\GridHandler->_getInitializedRowInstance()
#3 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1183): PKP\controllers\grid\GridHandler->renderRowsInternally()
#4 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1058): PKP\controllers\grid\GridHandler->renderGridBodyPartsInternally()
#5 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(729): PKP\controllers\grid\GridHandler->doSpecificFetchGridActions()
#6 [internal function]: PKP\controllers\grid\GridHandler->fetchGrid()
#7 /tmp/ojs/lib/pkp/classes/core/PKPRouter.php(333): call_user_func()
#8 /tmp/ojs/lib/pkp/classes/core/PKPComponentRouter.php(291): PKP\core\PKPRouter->authorizeInitializeAndCallRequest()
#9 /tmp/ojs/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPComponentRouter->route()
#10 /tmp/ojs/lib/pkp/classes/core/PKPApplication.php(372): PKP\core\Dispatcher->dispatch()
#11 /tmp/ojs/index.php(21): PKP\core\PKPApplication->execute()
#12 {main}
thrown in /tmp/ojs/lib/pkp/classes/submissionFile/Repository.php on line 704
[Thu Apr 27 10:00:58 2023] 127.0.0.1:33648 [500]: GET /index.php/publicknowledge/$$$call$$$/grid/event-log/submission-event-log-grid/fetch-grid?submissionId=11&=1682582418978 - Uncaught Error: Call to a member function getStageId() on null in /tmp/ojs/lib/pkp/classes/submissionFile/Repository.php:704
Stack trace:
#0 /tmp/ojs/lib/pkp/controllers/grid/eventLog/EventLogGridRow.php(91): PKP\submissionFile\Repository->getWorkflowStageId()
#1 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1220): PKP\controllers\grid\eventLog\EventLogGridRow->initialize()
#2 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1130): PKP\controllers\grid\GridHandler->_getInitializedRowInstance()
#3 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1183): PKP\controllers\grid\GridHandler->renderRowsInternally()
#4 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(1058): PKP\controllers\grid\GridHandler->renderGridBodyPartsInternally()
#5 /tmp/ojs/lib/pkp/classes/controllers/grid/GridHandler.php(729): PKP\controllers\grid\GridHandler->doSpecificFetchGridActions()
#6 [internal function]: PKP\controllers\grid\GridHandler->fetchGrid()
#7 /tmp/ojs/lib/pkp/classes/core/PKPRouter.php(333): call_user_func()
#8 /tmp/ojs/lib/pkp/classes/core/PKPComponentRouter.php(291): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()
#9 /tmp/ojs/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPComponentRouter->route()
#10 /tmp/ojs/lib/pkp/classes/core/PKPApplication.php(372): PKP\core\Dispatcher->dispatch()
#11 /tmp/ojs/index.php(21): PKP\core\PKPApplication->execute()
#12 {main}
thrown in /tmp/ojs/lib/pkp/classes/submissionFile/Repository.php on line 704
That’s all for the moment, thank you
Simon