Hi @drugurkocak,
That suggests that there are notifications that refer to non-existent queries (also known as the Discussions tool). I would suggest removing those entries in the notifications table.
Regards,
Alec Smecher
Public Knowledge Project Team
Hi @asmecher,
The problem was solved when I followed your suggestions.
Thank you very much for support and patience.
Regards,
Ugur Kocak
Hello all,
I’ve also started to have this problem with one user in one journal.
The error is PHP Fatal error: Call to a member function getSubmissionId() on a non-object in /var/www/html/lib/pkp/controllers/grid/notifications/NotificationsGridCellProvider.inc.php on line 117
And I’ve tried the first SQL statement, deleted the entry with that user_id but it is still the same. Or should I remove all the entries related to that journal?
EDIT: This happens in submissions menu, or in each submission
Thank you,
Best regards
Hi @digitojs,
What version of OJS are you using? (Please include this in your posts.)
Regards,
Alec Smecher
Public Knowledge Project Team
Hello @asmecher,
Sorry for skipping it, the topic was about 3.0.2 and I followed it.
It’s version 3.0.2.
Thank you,
Best regards
Hello,
In table review_round I searched for NULL review_revision and there are many entries with this value. For submissions of the journal of that particular user, but also for other journals.
I thought it could be the problem, but doesn’t look like it. And I don’t find any review_round that don’t have a submission_id associated, which seems to be the gap when he tries to catch it.
Thank you,
Best regards
Hello all,
Anyone has an idea?
Thank you,
Best regards
Hi @digitojs,
Please be patient – we’re a small team with a lot of competing priorities!
Try the following SQL query to identify problematic notifications:
SELECT n.* FROM notifications n LEFT JOIN review_rounds rr ON (n.assoc_id = rr.review_round_id) WHERE rr.review_round_id IS NULL AND n.assoc_type=523;
Regards,
Alec Smecher
Public Knowledge Project Team
Hi @asmecher,
Sorry if I seemed unpatient, I know the team never stops and do the best they can and I understand that, all the support I had was always perfect. In this case was for the chance of some user could have a similar issue, without having your attention.
Regarding your suggestion, the SQL throws some lines
being the user 1698 the one I mentioned. What is the cause of this problems? The related submission is old but there could be more
Thank you,
Best regards
Hi @digitojs,
Those are notifications that are associated with a nonexistent review round. I’m not sure where those came from, but checking the code, they appear to be cleaned up when a review round is deleted. I would suggest removing those entries from the database, and watching for the situation to recur. I suspect it won’t, but if it does, please see if you can provide some details on the process the submission followed.
Regards,
Alec Smecher
Public Knowledge Project Team
Hello @asmecher,
Thank you for your feedback.
I removed all those lines, and the problem for that user was solved.
But the first user in that list still has the same problem, and the error_log throws
PHP Fatal error: Call to a member function getSubmissionId() on a non-object in /var/www/html/lib/pkp/controllers/grid/notifications/NotificationsGridCellProvider.inc.php on line 111
complaining about the review_assignments. I changed and tried an SQL query to catch it but wrongly, I believe and with no results.
I deleted some review rounds for some submissions (stages issues at the time) and thought I made it smooth and clean, but guess not so it makes sense.
Thank you,
Best regards
Hi @digitojs,
The SQL statement I already listed above should catch this case – are you sure you deleted all rows in the notifications table that it responded with?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi @asmecher,
I deleted all rows, the SQL return 0 rows from notifications table. Then I tracked that user for review assignments ou rounds that could be missing but didn’t found them or notifications. But I will track it again.
Thank you,
Best regards
Hello,
That user (2281) still has the problem but everything looks fine.
His submissions are all ok, the reviews the same, the assignments too. The error log when he operates has his methods ok, he has 5 tasks and I deleted the 5 notifications for each, but still not loading the task menu.
He has some notifications with assoc_type of 0, 517, 522, and assoc_id of 0, and this seems the only thing I pick on.
Thank you,
Best regards
Hi @digitojs,
And to clarify, are you still seeing the same PHP log errors as you’ve posted above?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi @asmecher,
Yes, still the same PHP log errors.
When I log in as the specific troubled user, in error_log:
PHP Fatal error: Call to a member function getSubmissionId() on a non-object in /var/www/html/lib/pkp/controllers/grid/notifications/NotificationsGridCellProvider.inc.php on line 111, referer: http://aaaaaaa/submissions
In acces_log:
"GET /aaaaaaa/login/signInAsUser/2281 HTTP/1.1" 302 - "http:/aaaaaaa/management/settings/access" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/submissions HTTP/1.1" 200 24394 "http:/aaaaaaa/management/settings/access" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/page/page/tasks?_=1506501996838 HTTP/1.1" 200 1278 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/page/page/user-nav-backend?_=1506501996839 HTTP/1.1" 200 8350 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/submissions/myQueue?_=1506501996840 HTTP/1.1" 200 3032 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/submissions/my-submissions/my-submissions-list-grid/fetch-grid?_=1506501996844 HTTP/1.1" 200 8791 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/submissions/unassigned-submissions/unassigned-submissions-list-grid/fetch-grid?_=1506501996842 HTTP/1.1" 200 25537 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/notifications/task-notifications-grid/fetch-grid?_=1506501996841 HTTP/1.1" 200 180 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/submissions/assigned-submissions/assigned-submissions-list-grid/fetch-grid?_=1506501996843 HTTP/1.1" 200 35980 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
When accessing any existent submission:
erro_log
PHP Fatal error: Call to a member function getSubmissionId() on a non-object in /var/www/html/lib/pkp/controllers/grid/notifications/NotificationsGridCellProvider.inc.php on line 111, referer: http:/aaaaaaa/workflow/index/4233/3
access_log
"GET /aaaaaaa/workflow/access/4233 HTTP/1.1" 302 - "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/workflow/index/4233/3 HTTP/1.1" 200 24910 "http://aaaaaaa/submissions" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/page/page/tasks?_=1506502453376 HTTP/1.1" 200 1278 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"POST /aaaaaaa/notification/fetchNotification HTTP/1.1" 200 44 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/workflow/submissionHeader?submissionId=4233&stageId=3&contextId=submission&_=1506502453378 HTTP/1.1" 200 4368 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/page/page/user-nav-backend?_=1506502453377 HTTP/1.1" 200 8350 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/workflow/submissionProgressBar?submissionId=4233&stageId=3&contextId=submission&_=1506502453380 HTTP/1.1" 200 1661 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/tab/workflow/workflow-tab/fetch-tab?submissionId=4233&stageId=3&_=1506502453381 HTTP/1.1" 200 2501 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/notifications/task-notifications-grid/fetch-grid?_=1506502453379 HTTP/1.1" 200 180 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/tab/workflow/review-round-tab/external-review-round?submissionId=4233&stageId=3&reviewRoundId=2982&_=1506502453382 HTTP/1.1" 200 4087 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/queries/queries-grid/fetch-grid?submissionId=4233&stageId=3&_=1506502453383 HTTP/1.1" 200 12120 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"POST /aaaaaaa/notification/fetchNotification HTTP/1.1" 200 475 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/users/stage-participant/stage-participant-grid/fetch-grid?submissionId=4233&stageId=3&_=1506502453385 HTTP/1.1" 200 13744 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/files/review/workflow-review-revisions-grid/fetch-grid?submissionId=4233&stageId=3&reviewRoundId=2982&_=1506502453388 HTTP/1.1" 200 6048 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/workflow/editorDecisionActions?submissionId=4233&stageId=3&reviewRoundId=2982&contextId=reviewRoundTab-2982&_=1506502453384 HTTP/1.1" 200 4565 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/files/review/editor-review-files-grid/fetch-grid?submissionId=4233&stageId=3&reviewRoundId=2982&_=1506502453386 HTTP/1.1" 200 10975 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
"GET /aaaaaaa/$$$call$$$/grid/users/reviewer/reviewer-grid/fetch-grid?submissionId=4233&stageId=3&reviewRoundId=2982&_=1506502453387 HTTP/1.1" 200 36257 "http://aaaaaaa/workflow/index/4233/3" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0"
These are the outputs of each action and all seems fine.
Thank you!
Best regards
Hello,
I’m still experiencing this issue and I identified that it happens when a review is “hopped”. I mean, in the last situation I verified it, a user was assigned as a reviewer, and a new round was initiated and the same user assigned again as reviewer. I delete notifications but without a resolution for this cases.
Thank you,
Best regards
Hello everyone,
I know a lot of priorities at the moment are focused in the new release, but I would appreciate any observation from someone facing or that has faced the same issue.
Thank you,
Best regards
Hi @digitojs,
Can you describe how you hop a review? If I can duplicate this locally, I can resolve the cause of the bad data.
Regards,
Alec Smecher
Public Knowledge Project Team
Hello @asmecher,
Thank you for your reply.
This happens in two situations: one, when we delete a review_round in the DB (even trying to do it the most wide and cleaner way, problems remain), and two (the “hop” case): when in a review round (1) a reviewer is assigned and is left incomplete, and another review round (2) starts and the same reviewer is assigned, just by doing this the mentioned problem happens.
The two points, in a simpler way, mention the same: when a reviewer/review round is assigned/starts by mistake or is erroneous, the user/users related to that review round/review, stop having access to the Task menu.
I hope the description gives you the right interation map for you to test it locally.
Thank you,
Best regards