[solved] Editorial History can't load


We are using OJS
For a submission, Editorial History can’t load.

It seems to not be the same problem which was fixed for my version: [OJS] delete a note with a file in a query cause error500 for editorialhistory · Issue #4179 · pkp/pkp-lib · GitHub

My logs show this error:
PHP Fatal error: Uncaught Error: Call to a member function getStageId()
on null in /lib/pkp/classes/submission/SubmissionFileDAO.inc.php:763\nStack trace:\n#0 /lib/pkp/controllers/grid/eventLog/EventLogGridRow.inc.php(74):
SubmissionFileDAO->getWorkflowStageId(Object(SupplementaryFile))\n#1 /lib/pkp/classes/controllers/grid/GridHandler.inc.php(1062):

Problem appears in SubmissionFileDAO.inc.php file in function getWorkflowStageId($submissionFile), when stage is 4=SUBMISSION_FILE_REVIEW_FILE
When I comment the line “case SUBMISSION_FILE_REVIEW_FILE:”, it works

The submission has got 2 rounds.

Is there a file which has been deleted which could cause te problem ?

Thanks in advance for your answer.
Best regards.

Hi @hcl,

It sounds like you have a file that’s in the review stage but doesn’t have a matching review round. You can find it with this query:

SELECT sf.file_id, sf.revision, rrf.review_round_id
FROM submission_files sf
LEFT JOIN review_round_files rrf ON (sf.file_id = rrf.file_id AND sf.revision = rrf.revision)
LEFT JOIN review_rounds rr ON (rrf.review_round_id = rr.review_round_id)
WHERE sf.file_stage IN (4,5,15) AND rr.review_round_id IS NULL;

Alec Smecher
Public Knowledge Project Team

Hi @asmecher,

Problem solved! You were right. A round was deleted on the submission and files which were associated with this round were orphaned.

Thanks a lot.
Kind regards.

1 Like