Hi @asmecher
I using ojs-3.1.2-4 and i faced with 2 bug.
1: When a new issue published and checked to notify that " Send notification email to all registered users" in this file lib/pkp/classes/notification/PKPNotificationOperationManager.inc.php and in this part of code
if(!in_array($notificationType, $notificationEmailSettings)) {
$this->sendNotificationEmail($request, $notification, $contextId, $mailConfigurator);
}
call sendNotificationEmail function and in this function for getting mail template use this simple line but i believe that it is false
$mail = $this->getMailTemplate(âNOTIFICATIONâ);
instead of using like this
$mail = $this->getMailTemplate(âPUBLISH_NOTIFYâ);
I mean when ojs wants create a notification and send mail doesnât pay attention to notificationType in this function and always send mail with NOTIFICATION template.
2:When editor click on Request Revisions button and upload a new file to box of âSelect review files to share with the author(s)â it doesnât show to the author because its not viewable and when i check this file lib/pkp/controllers/modals/editorDecision/form/EditorDecisionWithEmailForm.inc.php
i faced with this condition in code:
if($submissionFile->getAssocType() == ASSOC_TYPE_REVIEW_ASSIGNMENT)
after that i check my record in submissionFile table and i see that the assocType of the new file uploaded is null and the fileStage equal to 13 (SUBMISSION_FILE_ATTACHMENT) so for solving this problem i added this code upper this condition
if(is_null($submissionFile->getAssocType()) && $submissionFile->getFileStage() == SUBMISSION_FILE_ATTACHMENT)
{
$submissionFile->setAssocType(ASSOC_TYPE_REVIEW_ASSIGNMENT); // Localized
$submissionFile->setFileStage(SUBMISSION_FILE_REVIEW_ATTACHMENT);
$submissionFileDao->updateObject($submissionFile);
}
As a result, all checked files are now accessible to the author.