QuickSubmit plugin leaves incomplete submission if canceled

aguen · January 2, 2019, 7:21am

If you open the QuickSubmit Plugin but then leave it by pressing “Cancel” (instead of “Save”) an Incomplete submission is generated (under “My Assigned”).

Not a big issue, as you can delete the incomplete submission - but anyway it’s a bug I guess.

ctgraham · January 2, 2019, 4:27pm

Confirmed. The “Cancel” link does delete the current submission, courtesy of the $form->cancel() call, but redirecting to the QuickSubmit input form again creates a new empty submission.

github.com

pkp/quickSubmit/blob/8621f53f47ec9521ce00a41fcd797206c58c39a5/QuickSubmitPlugin.inc.php#L93-L113


	/**
	 * Cancels the submission
	 * @param $args array
	 * @param $request Request
	 */
	function cancelSubmit($args, $request) {
		$this->import('QuickSubmitForm');
		$form = new QuickSubmitForm($this, $request);
		$form->readInputData();

		$form->cancel();

		// Submission removal notification.
		$notificationContent = __('notification.removedSubmission');
		$currentUser = $request->getUser();
		$notificationMgr = new NotificationManager();
		$notificationMgr->createTrivialNotification($currentUser->getId(), NOTIFICATION_TYPE_SUCCESS, array('contents' => $notificationContent));

		$path = array('plugin', $this->getName());
		$request->redirect(null, null, null, $path, null, null);
	}

I’m not sure what the preferred user experience is here. Should we redirect the user somewhere other than the input form when cancelling a submission?

aguen · January 3, 2019, 6:16am

My suggestion is to handel the situation in the same way as a “success” event (see function saveSubmit), but display a submitCancelled.tpl instead of ‘submitSuccess.tpl’:

$templateMgr->display($this->getTemplatePath() . 'submitCancelled.tpl');

ctgraham · January 3, 2019, 1:44pm

Seems reasonable. Are you comfortable with PHP and with GitHub? This could make a good pull request into the plugin.

ctgraham · January 14, 2019, 3:42pm

@aguen, you’ve done most of the work to identify the problem and solution here. I don’t want to steal your contribution, but I also don’t want to lose track of it. Would you be interested in opening a issue/pull request in Github for this?

aguen · January 15, 2019, 7:07am

Sorry for not replying sooner. I still have to learn GitHub but due to a heavy workload this needs some time. So I would be very glad if you could do the pull request. No problem with my contribution

ctgraham · January 15, 2019, 3:38pm

Filed here:
https://github.com/pkp/quickSubmit/pull/29

ivovolt · January 15, 2020, 12:00pm

Related to this, the “Cancel” at the end of quick submission page should include a warning before actually cancelling. I just accidentally hit it and the submission was lost.