Ordering issues and sections does not work in OJS 3.3.0

carola · November 24, 2021, 5:49pm

Hi,

ordering issues and sections does not work in at least two of our 3.3.0 installations. Tables “custom_issue_orders” and “custom_section_orders” are empty .

The problem was reported before, in older OJS versions:

When clicking “done” nothing happens.

Regards,
Carola

Update:

$this->getUserVar(‘csrfToken’) is empty.

error log: PHP Fatal error: Uncaught Exception: CSRF mismatch! in
…/lib/pkp/classes/controllers/grid/GridHandler.inc.php:752

sections seems to use column “seq”, but some values are 0.
sectiontable

jnoronha · November 25, 2021, 1:19am

Hi Carola,

There’s a commit addressing this issue. You need to cherry-pick it for the ordering to work. Let me know if you need any further assistence.

Best regards,

Josh Noronha (he/his)
Systems Specialist
PKP|PS Support Team

Subscribe to the PS Bulletin for quarterly updates on
PKP software, support, and community events

carola · November 25, 2021, 12:46pm

Hi @jnoronha,

thank you jnoronha, but I use OJS 3.3.0 and already have this code.

There seems to be a problem with

github.com

pkp/pkp-lib/blob/stable-3_3_0/classes/controllers/grid/GridHandler.inc.php#L752

    
      
          	/**
          	 * Hook opportunity for grid features to request a save items sequence
          	 * operation. If no grid feature that implements the saveSequence
          	 * hook is attached to this grid, this operation will only return
          	 * the data changed event json message.
          	 * @param $args array
          	 * @param $request PKPRequest
          	 * @return JSONMessage JSON object
          	 */
          	function saveSequence($args, $request) {
          		if (!$request->checkCSRF()) throw new Exception('CSRF mismatch!');
          
          
		$this->callFeaturesHook('saveSequence', array('request' => &$request, 'grid' => &$this));
          
          
		return DAO::getDataChangedEvent();
          	}
          
          
	/**
          	 * Get the js handler for this component.
          	 * @return string
          	 */

We have another 3.3.0 installation (tag 3_3_0-8-8-g30dae2974d) where this line is not yet there and ordering works. The newer installations (tag 3_3_0-8-18-g8665ac7121) have this line and the ordering problem. If I comment out this line, ordering works.

$this->getUserVar(‘csrfToken’) is empty, this is why the match fails.

Regards,
Carola

asmecher · November 26, 2021, 12:30pm

This appears to be a duplicate of this post; I’ll close this in favour of the other.

Regards,
Alec Smecher
Public Knowledge Project Team