OJS review form settings get deleted/overwritten on upgrade from 3.2 to 3.3

Software Support
,
12

Hi @asmecher,

May be it’s me but I think this change introduced a regression in 3.3.0-18.

Upgrade from 3.2 to 3.3 works like a charm till 3.3.0-17 (except for the review forms) but when I try to upgrade to -18, the upgrade script shows the following error:

2024-09-18 08:41:16 [migration: OJSv3_3_0UpgradeMigration]                                                                                                                                    
Failed to migrate the settings entity "object_for_review_settings"                                                                                                                            
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'setting_name' in 'field list' in /var/www/html/lib/pkp/lib/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.p
hp:80                                                                                                                                                                                         
Stack trace:                                                                                                                                                                                  
#0 /var/www/html/lib/pkp/lib/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php(80): PDO->prepare()                                                                              
#1 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(331): Doctrine\DBAL\Driver\PDOConnection->prepare()                                              
#2 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(664): Illuminate\Database\Connection->Illuminate\Database\{closure}()                            
#3 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(631): Illuminate\Database\Connection->runQueryCallback()
#4 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php(339): Illuminate\Database\Connection->run()
#5 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2270): Illuminate\Database\Connection->select()
#6 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2258): Illuminate\Database\Query\Builder->runSelect()
#7 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2753): Illuminate\Database\Query\Builder->Illuminate\Database\Query\{closure}()
#8 /var/www/html/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2259): Illuminate\Database\Query\Builder->onceWithColumns()
#9 /var/www/html/classes/migration/upgrade/OJSv3_3_0UpgradeMigration.inc.php(114): Illuminate\Database\Query\Builder->get()
#10 /var/www/html/classes/migration/upgrade/OJSv3_3_0UpgradeMigration.inc.php(37): OJSv3_3_0UpgradeMigration->_settingsAsJSON()
#11 /var/www/html/lib/pkp/classes/install/Installer.inc.php(406): OJSv3_3_0UpgradeMigration->up()
#12 /var/www/html/lib/pkp/classes/install/Installer.inc.php(252): Installer->executeAction()
#13 /var/www/html/lib/pkp/classes/install/Installer.inc.php(175): Installer->executeInstaller() 
#14 /var/www/html/lib/pkp/classes/cliTool/UpgradeTool.inc.php(89): Installer->execute()
#15 /var/www/html/lib/pkp/classes/cliTool/UpgradeTool.inc.php(65): UpgradeTool->upgrade()
#16 /var/www/html/tools/upgrade.php(22): UpgradeTool->execute()
#17 {main}

Process exits with the “Successfully” message, and the journal seams functional (testing in detail right now), but the error generates a kind of disquiet feeling.

It’s safe to upgrade to -18 even this error?

I tested jumping directly from stable-3.2 to 3.3.0-19 and then the upgrade breaks.

Reporting both issues in githHub to keep the track:

Cheers,
m.