OJS HTML articles

digitojs · August 16, 2017, 5:04pm

Hello,

After the upgrade to 3.0.2, the HTML articles that were fine in the previous install didn’t preserve the style and image files. The files are in the DB and files folder, but the the HTML display isn’t correct. I’ve tried to understand but without success…any suggestion?

Thank you
Best regards

asmecher · August 16, 2017, 5:56pm

Hi @digitojs,

I believe that’s already fixed, and will be released in the next version of OJS. For details on the fix, and a tool to apply the fix for existing 3.0.2 installs, see issue 2582.

Regards,
Alec Smecher
Public Knowledge Project Team

digitojs · August 17, 2017, 9:17am

Hello @asmecher,

Thank you for your answer.
According to this fix, I need to change that files in the commit and then create and run that script? I really didnt want to perform an upgrade process, or similar, but I was aware of something like this…

Best regards

asmecher · August 17, 2017, 3:30pm

Hi @digitojs,

Yes, you’d need to apply the code patch, then run the tool at the link above. The tool is provided so that you don’t have to e.g. run a full upgrade process to fix the files.

Of course, take a full backup before doing any of these steps.

Regards,
Alec Smecher
Public Knowledge Project Team

digitojs · August 17, 2017, 4:36pm

Hi @asmecher,

The thing is that my files, of the 3.0.2 stable release are a bit outdated of the ones presented in this branch. I don’t want to mess anything up,so should I change only the lines affected in that commit?

Thank you
Best regards

asmecher · August 17, 2017, 6:30pm

Hi @digitojs,

Yes, you can use the patch tool to just change the required lines. Then you’ll need to run the tool in the link above. Please back everything up before you do so.

Regards,
Alec Smecher
Public Knowledge Project Team

Enzo · August 24, 2017, 10:21am

Hi.
I had the same issue and can confirm: the issue 2582 patch works finely!

Thank you @asmecher.
Enzo

JCar · August 24, 2017, 8:28pm

Hi @asmecher, I have the same problem and I tried the solutions about 2582 but after I ran the file from tools/fixGalleyImages.php, the HTML display isn’t correct, it’s the same than before. The logs never show me what is happening when I ran the fixGalleyImages.php or when I can open the files in HTML, Do you have any sugestions?

asmecher · August 25, 2017, 3:22pm

Hi @JCar,

Did you apply the patch, or just run the tool?

Regards,
Alec Smecher
Public Knowledge Project Team

JCar · August 25, 2017, 4:10pm

Hi @asmecher,
I only ran the tool fixGalleyImages.php, Do you have patch? I upgraded ojs 2.4.8.1 to ojs 3.0.2, than after the upgrade the version 3.0.2 I can’t see the images from html files. I don’t know what is the patch than you ask me. Can you send me the link for the patch? thanks for all !!!

asmecher · August 25, 2017, 4:20pm

Hi @JCar,

The patch is at the link above, on the same comment where the fixGalleyImages.php tool is given.

Regards,
Alec Smecher
Public Knowledge Project Team

JCar · August 25, 2017, 4:50pm

hi @asmecher,
sorry I’m not expert user. Really I don’t see the patch. maybe i need to run that tools/upgrade.php patch ? or what is the steps for download and apply the patch, Can you help me please?

asmecher · August 25, 2017, 7:13pm

Hi @JCar,

It’s asmecher/ojs@361ec47; you can get the patch file here.

Regards,
Alec Smecher
Public Knowledge Project Team

JCar · August 25, 2017, 8:20pm

Hi @asmecher,
I have patch the files, after it I need to run again the file fixGalleyImages.php or what is the next step than I need to do ?

JCar · August 25, 2017, 9:56pm

Hi @asmecher,
I ran the fixGalleyImages.php and the problem is solved. I see the images in the html files. thanks for your patience and your help. Really thanks !!!

digitojs · August 28, 2017, 1:51pm

Hello,

I’ve tested it and he fix was successful, the images are associated again and without problems. Thank you! Although, the css isn’t and I don’t see what could be wrong, no errors, nothing was recorded. @asmecher, @Enzo, @JCar did you experience this?

Thank you again,
Best regards

digitojs · August 28, 2017, 2:47pm

Hello,

This is an example of an article in the test I’m performing.

test

Should those values be like that for the css file?

Edit: I checked and for what I realized those values aren’t correct, and it’s a problem that resulted from upgrade. Tried to change them manually, but didn’t make a difference either.
Best regards

Enzo · August 29, 2017, 8:27am

Hi, this is how I solved it.

/plugins/generic/htmlArticleGalley/display.tpl (line 30)

<div id="htmlContainer">    		
    {$htmlGalleyContents}
    <a href="#top" class="obj_galley_link go_top"></a>
    <!--  iframe name="htmlFrame" src="{**url page="article" op="download" path=$article->getBestArticleId()|to_array:$galley->getBestGalleyId() inline=true*}" allowfullscreen webkitallowfullscreen>
    </iframe  -->
</div>

/plugins/generic/htmlArticleGalley/HtmlArticleGalleyPlugin.inc.php (line 77)

$templateMgr->assign(array(
	'issue' => $issue,
	'article' => $article,
	'galley' => $galley,
	'htmlGalleyContents' => $this->_getHTMLContents($request, $galley),//Enzo's
));

I’m not sure it’s the best solution but the use of iframe tag to import the HTML files made impossible to apply CSS style to them (in display.tpl the journal CSS is loaded externaly from iframe).
I guess there is a valid reason of using iframe in OJS 3.0 but I couldn’t avoid to remove it and import html directly in div id="htmlContainer".
Waiting for a better solution (maybe in the next release).

Greetings,
Enzo

digitojs · August 29, 2017, 3:17pm

Hello,

Thank you for showing your solution @Enzo ! Unfortunately it doesn’t work totally. As I’d seen in other topics in the forum, the iframe is removed for this purpose and the style is recovered, but what I experience is an halfway result. It indeed gets the css, but the css that we upload in the journal admin options, not the css of the html. I’ve been around this but without success for now.

Edit: previously I posted a DB print ensuring the file type, and in inspector

testcss

At the same time it is related with the error log:

PHP Fatal error: Call to a member function getRemoteURL() on a non-object in /var/www/html/pages/article/ArticleHandler.inc.php on line 230

but when removing iframe it is gone. Or should I apply the commits open for this issue?

Edit2: browser inspector throws

The stylesheet http:/*****.css was not loaded because its MIME type, “text/html”, is not “text/css”.

In php.ini, changed default_mimetype = “text/html” to default_mimetype = “”, but didn’t work.

Thank you,
Best regards

bozana · August 31, 2017, 11:05am

Hi all,

I’ve just tested the CSS integration within HTML galleys with the latest OJS code and it works if you have embedded the CSS in your HTML code, something like:
<link rel="stylesheet" type="text/css" href="article.css">
and if you have uploaded article.css file as the HTML galley dependent.
(This is also how OMP functions.)

But, I am not sure if the OJS 2.4.x users had that line in their HTML code… – @digitojs, do you have such a line in the header of your HTML galley files?

EDIT: the HTML galleys are handled differently in OJS 3 – they are now standalone files and displayed i.e. downloaded as they are. Thus it seems that they should always contain their CSS.
@asmecher, that way (either using the htmlArticleGAlley plugin with the iframe or just using the article download) also the OJS journal CSS is not applied to the HTML files. Just in case the htmlArticleGAlley plugin is used and the iframe removed, as @Enzo reported.
Shall this be so?

Best,
Bozana