OJS 3 - More information showing not names but variables?

Software Support
1

When I click on More information I see:

2016-11-06 Marry Bakoleva Revision “{$name}” (file ID 294-{$revision}) was uploaded.

Strange, but some are showing ok, with the names and filenames. Is this normal from the upgrade from OJS 2 and to not bother?

2

Also noted this in some emails dialog windows:
Is this normal and after sending will be replaced or?

3

Hi @vebaev,

The second issue you report regarding {$journalTitle} is this one.

Regards,
Alec Smecher
Public Knowledge Project Team

4

I see,

PS
Just for the report I see also another ones sowing there:

{$abstractTermIfEnabled}
{$editorialContactName}

If I know the new variables I can replace them in Emails?

5

Hi @vebaev,

The first is corrected with this commit.

As for the second ({$editorialContactName}), which template are you seeing this appear in? (You can look for the text in e.g. locale/en_US/emailTemplates.xml.)

Regards,
Alec Smecher
Public Knowledge Project Team

6

Second is appear in Able to Review

7

Hi @vebaev,

That’s no longer in the default email template language – see this commit that removed it.

Regards,
Alec Smecher
Public Knowledge Project Team

8

Hi,
I don’t quite understand this issue. Our email template xml-file does not have the {$editorialContactName} field, but the template shown in the frontend does (running OJS 3.0.2, database upgraded from 2.4). Does that mean that the template used is from the old system, but not compatible with OJS 3?

Simon

9

Hi @simonmitternacht,

That variable should also be removed during upgrade (see this SQL). Are you seeing this in a template other than the ones listed in the SQL statements?

Regards,
Alec Smecher
Public Knowledge Project Team

10

I have it in 26 rows, some duplicates between locales. The following sql command

> select email_key, locale from email_templates_default_data where body like '%$editorialContactName%';

gives the following results

         email_key         | locale
---------------------------+--------
 LAYOUT_COMPLETE           | en_US
 EDITOR_ASSIGN             | en_US
 LAYOUT_COMPLETE           | nb_NO
 COPYEDIT_COMPLETE         | nb_NO
 COPYEDIT_AUTHOR_COMPLETE  | nb_NO
 PROOFREAD_AUTHOR_COMPLETE | en_US
 REVISED_VERSION_NOTIFY    | pt_BR
 PROOFREAD_COMPLETE        | nb_NO
 REVIEW_COMPLETE           | nb_NO
 COPYEDIT_AUTHOR_COMPLETE  | en_US
 PROOFREAD_LAYOUT_COMPLETE | en_US
 REVIEW_CONFIRM            | en_US
 REVIEW_COMPLETE           | en_US
 COPYEDIT_FINAL_COMPLETE   | en_US
 PROOFREAD_COMPLETE        | en_US
 REVISED_VERSION_NOTIFY    | nl_NL
 REVISED_VERSION_NOTIFY    | en_US
 REVISED_VERSION_NOTIFY    | eu_ES
 REVISED_VERSION_NOTIFY    | uk_UA
 REVIEW_DECLINE            | nb_NO
 REVIEW_CONFIRM            | nb_NO
 PROOFREAD_AUTHOR_COMPLETE | nb_NO
 PROOFREAD_LAYOUT_COMPLETE | nb_NO
 COPYEDIT_COMPLETE         | en_US
 EDITOR_ASSIGN             | nb_NO
 COPYEDIT_FINAL_COMPLETE   | nb_NO
(26 rows)

We did the upgrade via 3.0.0 in january and then to 3.0.1 and 3.0.2.

11

Hi @simonmitternacht,

The {$editorialContactName} variable should be present in LAYOUT_COMPLETE, EDITOR_ASSIGN, and REVISED_VERSION_NOTIFY. Edit your email templates to remove it from REVIEW_CONFIRM and REVIEW_DECLINE. (The query above should have taken care of this, but is language-specific, and doesn’t include all the languages you’re using.)

The templates COPYEDIT_AUTHOR_COMPLETE, COPYEDIT_COMPLETE, COPYEDIT_FINAL_COMPLETE, PROOFREAD_AUTHOR_COMPLETE, PROOFREAD_COMPLETE, PROOFREAD_LAYOUT_COMPLETE, and REVIEW_COMPLETE are no longer used in OJS 3.x and can be ignored or removed.

Regards,
Alec Smecher
Public Knowledge Project Team

12

Ok, thanks @asmecher !

Simon