[OJS 3] Lost of text formatting?

vebaev · November 15, 2016, 5:07pm

I have noticed on system wide issue that all formatting is lost on messages (Discussions), imported reviewers forms , emails etc, all formatting I have send or done are lost even new lines are removed, the result is this:

Can someone recommend me how to fix it as it is quite an issue? Especially when reviewers answers are imported and entries are mixed in one paragraph. And with “Add discussions” I have specifically bolded some parts and paragraphs and this is also lost after it is sent).

Here is a shot:

vebaev · November 17, 2016, 8:53am

Hi,

anyone see the same issue or a fix on that? @asmecher ?

ajnyga · November 17, 2016, 9:15am

Hi,

It could be that this is not related, but check your config.inc.php settings for:
allowed_html = "a[href|target|title],em,strong,cite,code,ul,ol,li[class],dl,dt,dd,b,i,u,img[src|alt],sup,sub,br,p"

Do you have that or this:
allowed_html = "<a href|target> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd> <img src|alt> "

vebaev · November 17, 2016, 10:18am

I will check, which of these 2 should I have or both are ok?

ajnyga · November 17, 2016, 10:23am

Hi,

The first one is the format used in OJS3. The second one is the old format used in OJS2.

vebaev · November 17, 2016, 10:26am

I have this in my file:

; tags for fields that permit restricted HTML.
; For PHP 5.0.5 and greater, allowed attributes must be specified individually
; e.g. <img src|alt> to allow "src" and "alt" attributes. Unspecified
; attributes will be stripped. For PHP below 5.0.5 attributes may not be
; specified in this way.
allowed_html = "<a href|target> <em> <strong> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd> <b> <i> <u> <img src|alt> <sup> <sub> <br> <p>"

ajnyga · November 17, 2016, 10:28am

Ok, so that could be the reason to your problems, because OJS3 is using a different format:

github.com

pkp/ojs/blob/main/config.TEMPLATE.inc.php

; <?php exit(); // DO NOT DELETE?>
; DO NOT DELETE THE ABOVE LINE!!!
; Doing so will expose this configuration file through your web site!
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;
; config.TEMPLATE.inc.php
;
; Copyright (c) 2014-2021 Simon Fraser University
; Copyright (c) 2003-2021 John Willinsky
; Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
;
; OJS Configuration settings.
; Rename config.TEMPLATE.inc.php to config.inc.php to use.
;
;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

This file has been truncated. show original

vebaev · November 17, 2016, 10:31am

This probably is from OJS2 upgrade since they required config file to be keept from the old one?
So How to fix it, should I just replace the

allowed_html = "<a href|target> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd> <img src|alt> "

with

allowed_html = "a[href|target|title],em,strong,cite,code,ul,ol,li[class],dl,dt,dd,b,i,u,img[src|alt],sup,sub,br,p"

ajnyga · November 17, 2016, 6:08pm

I guess so. I actually have to find out as well when exactly should that setting be changed, before upgrading from 2.0 to 3.0 or right after that? @asmecher?

asmecher · November 18, 2016, 4:30am

Hi @ajnyga,

That filter is applied before data is displayed, not when data is saved to the database, so the time of changing the setting isn’t important. Either way is fine.

Regards,
Alec Smecher
Public Knowledge Project Team

pverberne · May 8, 2017, 11:03am

Thanks vebaev.
The upgrade from 2.x to 3 does not support the new ojs3 allowed_html. This helped me for now with my upgrade.