[OJS 3.0.2] Deleting any issue shuffles the order of issues in the Archive

Ph_We · July 18, 2017, 2:43pm

Hi! Deleting any issue shuffles the order of issues in the Archive. Is it for me only?
I’ve run out of archives I could shuffle (test). The issue is being reproduced stably.

ctgraham · July 20, 2017, 4:14pm

Can you share some exact steps to reproduce the problem? Do you have to set up a custom issue ordering first? What unexpected reordering happens when an issue is deleted?

Ph_We · July 20, 2017, 4:57pm

@ctgraham, I was lucky to find another test archive to record a video.

We have a lot of large archives, normally sorted by Year/Volume/Number. After deleting of any issue (and refreshing the page) all the other issues get sorted randomly (I cannot see any system in this).

ctgraham · July 20, 2017, 6:31pm

I was able to replicate this on a journal where I had freshly imported new articles and issues without a custom issue order.

I’ll bet my lunch that this code needs a wrapper of if ($this->customIssueOrderingExists($issue->getJournalId())):

github.com

pkp/ojs/blob/ojs-stable-3_0_2/classes/issue/IssueDAO.inc.php#L496-L497


		$this->update('DELETE FROM custom_issue_orders WHERE issue_id = ?', (int) $issueId);
		$this->resequenceCustomIssueOrders($issue->getJournalId());

Or, perhaps better, IssueDAO::resequenceCustomIssueOrder() should check itself.

github.com

pkp/ojs/blob/ojs-stable-3_0_2/classes/issue/IssueDAO.inc.php#L669-L695


	/**
	 * Sequentially renumber custom issue orderings in their sequence order.
	 * @param $journalId int
	 */
	function resequenceCustomIssueOrders($journalId) {
		$result = $this->retrieve(
			'SELECT i.issue_id FROM issues i LEFT JOIN custom_issue_orders o ON (o.issue_id = i.issue_id) WHERE i.journal_id = ? ORDER BY o.seq',
			(int) $journalId
		);

		for ($i=1; !$result->EOF; $i++) {
			list($issueId) = $result->fields;
			$resultB = $this->retrieve('SELECT issue_id FROM custom_issue_orders WHERE journal_id=? AND issue_id=?', array($journalId, $issueId));
			if (!$resultB->EOF) {
				$this->update(
					'UPDATE custom_issue_orders SET seq = ? WHERE issue_id = ? AND journal_id = ?',
					array($i, $issueId, $journalId)
				);
			} else {
				// This entry is missing. Create it.

This file has been truncated. show original

ctgraham · July 20, 2017, 7:13pm

@Ph_We, you are welcome to test this fix, if desired:
https://github.com/pkp/pkp-lib/issues/2663

For journals where custom issue ordering has been turned on incorrectly and randomly by this action of deleting an issue, you can clear the custom_issue_orders for that journal_id to restore the default of sorting by publication date.

Ph_We · July 20, 2017, 7:21pm

@ctgraham, thanks very much for this. Unfortunately, I cannot test it now. But I was fortunate to test the issue deletion procedure on our test server before recommending it to the user

Anyway, we had to clear the custom_issue_orders for that issue, but because of this one:
https://github.com/pkp/pkp-lib/issues/2376

BTW, do you know if this latter issue will be resolved in OJS 3.1 (it is not tagged)?

ctgraham · July 20, 2017, 8:04pm

Since the QuickSubmit plugin is not packaged inside of OJS, I’m not sure how strong the correlation is between tagging something for “OJS 3.1” in an external plugin is. I would expect that the latest compatible version of a plugin could be pulled from the plugin gallery, potentially even before OJS 3.1 is officially released.

@asmecher, can you comment on the relationship of application releases to plugin releases? What is our intent in synchronizing these (or not)?

Ph_We · July 20, 2017, 9:12pm

Oh, I did not notice that issue was related to the plugin. I was sure QuickSubmit was a part of the core codebase. And I think, it should really be, since it is used quite often.