Non-expiring indivudal subscriptions: No access to PDFs (OJS 3.2.1.3)

bibliothekswelt · January 29, 2021, 9:46am

We have a problem with non-expiring individual (login-based) subscriptions. When you add a user to a non-expiring subscription, the user can’t access the PDFs. May be that’s because you can’t enter a start date for a non-ending-subscription? There’s no problem, when you add a user to a subscription type, which is 1-year based.

Here are some screenshots

User with 1-year-subscription

biuz_payment_individual-subscription_1year

User can access PDF

biuz_frontdoor_individual-subscription-1year

User with non-ending subscription

biuz_payment_individual-subscription_non-expiring

User can’t access PDF

biuz_frontdoor_individual-subscription-non-expiring

crowesn · January 5, 2022, 4:08pm

We are encountering this issue as well with 3.2.1.1

crowesn · January 5, 2022, 6:54pm

When I change the digits to true or false in this literal sql statement, the bug is resolved.

github.com

pkp/ojs/blob/stable-3_2_1/classes/subscription/IndividualSubscriptionDAO.inc.php#L494

    
      
          		}
          
          
		$result = $this->retrieve('
          			SELECT	s.subscription_id
          			FROM	subscriptions s
          				JOIN subscription_types st ON (s.type_id = st.type_id)
          			WHERE	s.user_id = ?
          				AND s.journal_id = ?
          				AND s.status = ' . SUBSCRIPTION_STATUS_ACTIVE . '
          				AND st.institutional = 0
          				AND ((st.non_expiring = 1) OR (st.non_expiring = 0 AND (' . $dateSql . ')))
          				AND (st.format = ' . SUBSCRIPTION_TYPE_FORMAT_ONLINE . '
          				OR st.format = ' . SUBSCRIPTION_TYPE_FORMAT_PRINT_ONLINE . ')',
          			array(
          				(int) $userId,
          				(int) $journalId
          			)
          		);
          
          
		if ($result->RecordCount() != 0) $returner = (boolean) $result->fields[0];
          		else $returner = false;

OS platform Linux
PHP version 7.3.20
Apache version Apache/2.4.37 (Oracle Linux) mod_fcgid/2.3.9
Database driver mysqli
Database server version 10.3.28-MariaDB

[database]
driver mysqli
port 3306
persistent Off
debug Off

Thoughts?

crowesn · January 5, 2022, 8:01pm

I should clarify that the true and false values are quoted:

AND ((st.non_expiring = "true") OR (st.non_expiring = "false" AND (' . $dateSql . ')))

asmecher · January 6, 2022, 8:24pm

Cross-filed: No access granted for non-expiring subscription · Issue #7596 · pkp/pkp-lib · GitHub

@crowesn, thanks for tracking this down; it’s best to just post an issue in one place, or if posting in multiple places, to cross-link them to keep organized. I’ll close this in favour of the github issue.

Regards,
Alec Smecher
Public Knowledge Project Team

asmecher · January 7, 2022, 4:00pm

This topic was automatically closed after 19 hours. New replies are no longer allowed.