Hi Alec
Thanks for your response. In my development environment (where I have upgraded to 2.4.8-5), I can see two basic types of error messages. These are coming from the apache logs, so they will follow their conventions as to the classification of the severity. Most of the logged lines look like:
[Mon Jul 15 10:40:27.474978 2019] [:error] [pid 4263] [client 127.0.0.1:47082] ojs2 has produced an error\n Message: WARNING: Declaration of DOAJPlugin::display($args, $request) should be compatible with ImportExportPlugin::display(&$args, $request)\n In file: …/plugins/importexport/doaj/DOAJPlugin.inc.php\n At line: 0\n Stacktrace: \n Server info:\n OS: Linux\n PHP Version: 7.0.33-0ubuntu0.16.04.5\n Apache Version: Apache/2.4.18 (Ubuntu)\n DB Driver: mysqli\n DB server version: 5.7.26-0ubuntu0.16.04.1, referer: http://local.ojs-currents.com/index.php/currents/user
Even though apache classifies this as an “error”, I believe we would be agree that this is really only a warning. When I look at the Home page, I’m seeing 50+ of these, and when I look at an Admin page, I’m seeing amost 20. Something of note, a recurring theme for ALL of these is that they deal with and are referencing some sort of Plugin. Since the PHP level has been increased to v7, should I also be upgrading the Plugins as well? I didn’t see any sort of reference to that in the upgrade documentation (but maybe I simply overlooked it).
Each hit of the Home or Admin page also get these lines added to the the apache log:
[Mon Jul 15 10:42:57.313326 2019] [:error] [pid 4416] [client 127.0.0.1:47098] PHP Deprecated: Non-static method PKPApplication::defineExposedConstant() should not be called statically in …/lib/pkp/classes/core/PKPApplication.inc.php on line 545, referer: …/index.php/currents/index
I’m less confident that a PHP Deprecated error would be a cosmetic error. This is not a fatal error, which would cause the server to stop executing the code, but it could lead to unexpected results.
Your talking about the error levels and your attempts to work out the warnings, I completely understand. I’ve had similar experiences in upgrades that I’ve worked on. What I’m now thinking is that the upgrade I did from v2.4.8-1 to 3.1.2.1 may have gone better than I thought. However, I can see a fatal error shown the the error_log file in the ojs root directory. When trying to access an admin page I get this error, which surely must be the reason the that admin theme does not look correct (and is giving my themer signification trouble trying to work with that version). Here is the fatal error that I’m seeing:
[15-Jul-2019 10:53:18 America/Chicago] PHP Fatal error: Uncaught Less_Exception_Parser: File styles/structure/index.less
not found. in index.less in …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Parser.php:2793
Stack trace:
#0 …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Parser.php(471): Less_Parser->Error(‘File `styles/st…’)
#1 …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Tree/Import.php(275): Less_Parser->parseFile(‘styles/structur…’, ‘styles/structur…’, true)
#2 …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Tree/Import.php(198): Less_Tree_Import->ParseImport(‘styles/structur…’, ‘styles/structur…’, Object(Less_Environment))
#3 …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(248): Less_Tree_Import->compile(Object(Less_Environment))
#4 …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(235): Less_Tree_Ruleset->evalImports(Object(Less_Environment))
#5 … in …/lib/pkp/lib/vendor/oyejorge/less.php/lib/Less/Parser.php on line 2793
So, I have these questions: 1) do I need to upgrade Plugins, 2) do you think that my 2 to 3 upgrade went well enough that we should focus our attention on that fatal error, and, of course, 3) how do I get around the index.less problem?