Fixed bug in contry code for Serbia

lucien · November 24, 2015, 1:43pm

in file cache/fc-country-en_US.php - add line ‘CS’ => ‘Serbia and Montenegro’,
in file cache/fc-country-pl_PL.php - ‘CS’ => ‘Serbia’, change to ‘RS’ => ‘Serbia’, and add ‘CS’ => ‘Serbia and Montenegro’,

ctgraham · November 24, 2015, 1:54pm

The source of these cached files will be in " lib / pkp / locale / localeCode / countries.xml "

For example:

github.com

pkp/pkp-lib/blob/ojs-dev-2_4/locale/en_US/countries.xml

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE countries SYSTEM "../../dtd/countries.dtd">

<!--
  * locale/en_US/countries.xml
  *
  * Copyright (c) 2013-2019 Simon Fraser University
  * Copyright (c) 2000-2019 John Willinsky
  * Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.
  *
  * Localized list of countries. Based on ISO 3166-1.
  *
  -->
<countries>
	<country name="Afghanistan" code="AF"/>
	<country name="Åland Islands" code="AX"/>
	<country name="Albania" code="AL"/>
	<country name="Algeria" code="DZ"/>
	<country name="American Samoa" code="AS"/>
	<country name="Andorra" code="AD"/>

This file has been truncated. show original

lucien · November 24, 2015, 2:14pm

Ouh sorry yes you are right.
But the correction is necessary for:
lib/pkp/locale/en_US/countries.xml add line

<country name="Serbia and Montenegro" code="CS"/>

and in
lib/pkp/locale/pl_PL/countries.xml change

<country name="Serbia" code="CS"/>

to <country name="Serbia" code="RS"/> and add

<country name="Serbia i Czarnogóra" code="CS"/>

Regards

asmecher · November 24, 2015, 7:14pm

Hi @lucien,

We use the ISO3166-1 standard country list:

The current revision doesn’t list “Serbian and Montenegro”, but has “Serbia” and “Montenegro” with separate entries.

Regards,
Alec Smecher
Public Knowledge Project Team

lucien · November 25, 2015, 8:09am

Hi http://forum.pkp.sfu.ca/users/asmecher

Yes of ae right, but you heve outdated list of OJS 2.4.7.1 for:
pl_PL - the file does not have the position of Montenegro

<country name="Czarnogóra" code="ME"/>

and Serbia has code CS it should be

<country name="Serbia" code="RS"/>

Capo Verde: <country name="Republika Zielonego Przylądka" code="CV"/>

Redgards

asmecher · November 30, 2015, 10:33pm

Hi @lucien,

Yes, it looks like our files are out of date. I’ve filed an issue and we should be merging in updated files shortly:

Regards,
Alec Smecher
Public Knowledge Project Team