Extract and save references - extra line spacing

ctgraham · December 5, 2018, 6:50pm

The problem is here:

pkp/pkp-lib/blob/23ba62f8c0cc62d16c513810c1a1ef19705acf4e/classes/citation/CitationListTokenizerFilter.inc.php#L52


		// 2) Remove trailing/leading line breaks.
		$input = trim($input, "\n");
		// 3) Break up at line endings.
		if (empty($input)) {
			$citations = array();
		} else {
			$citations = explode("\n", $input);
		}
		// 4) Remove numbers from the beginning of each citation.
		foreach($citations as $index => $citation) {
			$citations[$index] = PKPString::regexp_replace('/^\s*[\[#]?[0-9]+[.)\]]?\s*/', '', $citation);
		}

		return $citations;
	}
}

We’re trying to strip out the numbering from numbered citations, but there isn’t clear definition of when the numbering ends. As the code stands, the number could optionally end with a period, close parenthesis, closing square brace, plus 0 or more spaces. The “21” in “21st” matches this and is stripped.

Our regex here needs to consider this.

In your original question, is the “empty line” between references present in the actual data (as a blank reference), or is this just a matter spacing within the display?