eLens plugin for OJS 2.4.x branch?

marc · October 3, 2016, 1:11pm

Hi all,

Recent announcements (see: https://xmljatsredalyc.org) had side effects in my university and some journals are asking to include eLens viewer in their OJS installations.

I took a look to @asmecher 's eLens plugin:

github.com

asmecher/lensGalley/blob/master/LensGalleyPlugin.inc.php

<?php

/**
 * @file plugins/generic/lensGalley/LensGalleyPlugin.inc.php
 *
 * Copyright (c) 2014-2021 Simon Fraser University
 * Copyright (c) 2003-2021 John Willinsky
 * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
 *
 * @class LensGalleyPlugin
 * @ingroup plugins_generic_lensGalley
 *
 * @brief Class for LensGalley plugin
 */

import('lib.pkp.classes.plugins.GenericPlugin');

class LensGalleyPlugin extends GenericPlugin {
	/**
	 * @copydoc LazyLoadPlugin::register()

This file has been truncated. show original

But looks like is for OJS 3.x, so the question is: Did somebody test it successfully in OJS 2.4.x branch? If it’s not compliant, what need to be done to be ported?

Yes… I tried installing it on a 2.4.x branch and then I uploaded a xml galley (mime application/xml), but OJS downloads the xml file instead of including the JS header and link to the xml as one should expect.

Thanks for your time,
m.

marc · October 4, 2016, 4:31pm

Is bumping allowed by forum netiquette?

asmecher · October 5, 2016, 6:33pm

Hi @marc,

Bumping is permitted but not always effective

The eLens plugin is just for OJS 3.x, unfortunately. If you wanted to add the lens viewer to OJS 2.4.x, you might look at melding details of the 3.0 plugin with the overall structure of the PDF.js viewer for OJS 2.4.x. These are all relatively small plugins (=not much code to wrestle with).

Regards,
Alec Smecher
Public Knowledge Project Team

marc · October 6, 2016, 10:12am

Perfect feedback. Thanks.

I always have doubts about the best branch to work on… I hope ojs-dev-2_4 will be fine.

Looks quite simple so I hope to send something back very soon.

Cheers,
m.

asmecher · October 6, 2016, 2:05pm

Hi @marc,

I’d suggest working with ojs-stable-2_4_8 – that’s up-to-date and stable. The ojs-dev-2_4 branch will be close but possibly not as stable. (Remember to check out the same branch for the app and lib/pkp submodule!)

Regards,
Alec Smecher
Public Knowledge Project Team

simonmitternacht · January 23, 2017, 12:22pm

Has there been any development here? I might also be interested in this for 2.4.8.

asmecher · January 23, 2017, 8:23pm

Hi @simonmitternacht,

Still only available for OJS 3.x as far as I’m aware, I’m afraid.

Regards,
Alec Smecher
Public Knowledge Project Team

marc · January 24, 2017, 10:16am

Nope. Sorry but the project was canceled and I stop working on it.

I’m unsure if it will be renewed… because if we got time it’s smarter dedicate it to migrate to OJS 3.x.