Edit current unfinished translations

vvucic · May 26, 2015, 4:05pm

I did not change anything before I started to translate. the only change was putting closing tag and removing it today.

You can check localce.xml
here
http://politickeperspektive.org/locale.xml
Please let me know if I can help.

Thanks

asmecher · May 26, 2015, 4:56pm

Hi all,

I suspect this might be to do with the fact that the English default section policy locale key is an empty string. @ctgraham, could you describe what you were able to reproduce? Maybe I can reproduce it here.

Regards,
Alec Smecher
Public Knowledge Project Team

vvucic · May 26, 2015, 5:27pm

When I use Translator plugin I found the following missing key:
The key “plugins.generic.sword.descriptionUnsupported” is missing from “plugins/generic/sword/locale/sr_SR/locale.xml”. The English version has been provided as a default.
Reference Version
Allow Journal Managers and (optionally) Authors to deposit articles via the SWORD protocol. Note that this plugin requires the Zip extension, which is currently NOT installed.
I translate it and after clicking on Save button it appears again like not being translated.
Thanks

ctgraham · May 26, 2015, 6:25pm

My earlier suggestion that the locale key had a closing tag was incorrect. The closing tag is missing in dev-2_4:

github.com

pkp/ojs/blob/ojs-dev-2_4/locale/sr_SR/locale.xml#L75


	 *
	 * ENTITIES - This section contains terms pertaining to the system's
	 *            major entities, e.g. Article, Journal, Section
	 *
	 --><!--  Common Section Terms  --><message key="section.section">Sekcija</message>
	<message key="section.sections">Sekcije časopisa</message>
	<message key="section.title">Naslov sekcije</message>
	<message key="section.abbreviation">Skraćenica</message>
	<message key="section.abbreviation.example">(Npr. Članci=ČLA)</message>
	<message key="section.default.policy"/>

	<!--  Common Article Terms  --><message key="article.articles">Članci</message>
	<message key="article.submissionId">ID podneska članka</message>
	<message key="article.title">Naslov</message>
	<message key="article.authors">Autori</message>
	<message key="article.indexingInformation">Informacija oindeksiranju</message>
	<message key="article.metadata">Metapodaci</message>
	<message key="article.journalSection">Rubrika časopisa</message>
	<message key="article.file">Datoteka</message>
	<message key="article.suppFile">Dopunska datoteka</message>
	<message key="article.suppFiles">Dopunska datoteka (e)</message>

Without the closing tag, the logic fails at:
https://github.com/pkp/pkp-lib/blob/master/classes/file/EditableLocaleFile.inc.php#L92

Adding the closing tag resolved the issue for me.

Better might be to add a check for an empty XML tag at:
https://github.com/pkp/pkp-lib/blob/master/classes/file/EditableLocaleFile.inc.php#L98

asmecher · May 26, 2015, 6:45pm

Hi @vvucic,

Just to make sure, when you added the closing tag to…

<message key="section.default.policy"/>

…did you change it to…

<message key="section.default.policy"></message>

…or the following?

<message key="section.default.policy"/></message>

That last example is invalid XML and would probably explain why more content was showing up untranslated.

Regards,
Alec Smecher
Public Knowledge Project Team

vvucic · May 26, 2015, 6:58pm

I closed tag as you suggested and issue was repeated. The missing key appeared again after being translated and saved.
Please see attach.
Thanks

vvucic · May 27, 2015, 10:14pm

I noticed that the missing key was after saving repeated and when I translated it twice and saved it disappeared from the list of missing keys.
Strange but true.

Thanks