Do Images get corrupted in OJS 3.1.2-4?

GrazingScientist · March 5, 2020, 12:07pm

Application Version: OJS 3.1.2
Description of issue
I am using the embedGalley Plugin. This plugin calls images from their OJS URL e.g. www.my-journal.com/myjournal/article/download/3/36/200 , which then returns a jpg.

This worked fine in OJS 3.1.1-4, images where shown probperly. But now, in OJS 3.1.2-4, the images cannot be loaded anymore. My colleague found out, that OJS inserts a newline in the beginning of the image file binary in OJS 3.1.2-4, which it did not in OJS 3.1.1-4.

Is this my fault or a bug?

Cheers,

Adrian

asmecher · March 5, 2020, 3:30pm

Hi @GrazingScientist,

It looks like there’s a problem with extra whitespace at the end of one of the PHP files. See this issue and pull request: Fix whitespace problem with binaries (images) · Issue #8 · ajnyga/embedGalley · GitHub

Regards,
Alec Smecher
Public Knowledge Project Team

GrazingScientist · March 6, 2020, 4:41am

Solved the issue at least partly. For the rest, I have to investigate further and perhaps write again!

Thank you, Alec!