Descending order in the Archives page

alirezaaa · September 29, 2016, 5:23am

Hello,
We have many thousands of articles in the archive and it would be a great help to order them descending by default.
I tried EditorSubmissionDAO.inc.php and changed $sortDirection in the input parameters of these two functions, but it did not work:
function &getEditorSubmissionsArchives($journalId, $sectionId, $editorId, $searchField = null, $searchMatch = null, $search = null, $dateField = null, $dateFrom = null, $dateTo = null, $rangeInfo = null, $sortBy = null, $sortDirection = SORT_DIRECTION_DESC) {....}
and

function &_getUnfilteredEditorSubmissions($journalId, $sectionId = 0, $editorId = 0, $searchField = null, $searchMatch = null, $search = null, $dateField = null, $dateFrom = null, $dateTo = null, $additionalWhereSql, $rangeInfo = null, $sortBy = null, $sortDirection = SORT_DIRECTION_DESC) {....}

If I change $sortDirection inside the functions, the articles will be sorted desccending, but the sorting behaviour of the grid will not work anymore.
Could you help me on this topic?
We are on OJS-2.4.6

Best,
Ali

ctgraham · September 29, 2016, 1:42pm

The default view of the archives is handled by journalName/editor/submissions/submissionsArchives, so look for the page handler in pages/editor. “submissions” is handled by pages.editor.EditorHandler:

github.com

pkp/ojs/blob/ojs-2_4_6-0/pages/editor/index.php#L204-L211


	case 'submissions':
	case 'setEditorFlags':
	case 'deleteEditAssignment':
	case 'assignEditor':
	case 'deleteSubmission':
	case 'instructions':
		define('HANDLER_CLASS', 'EditorHandler');
		import('pages.editor.EditorHandler');

The function submissions handles the default sort here:

github.com

pkp/ojs/blob/ojs-2_4_6-0/pages/editor/EditorHandler.inc.php#L176-L179


		$sort = $request->getUserVar('sort');
		$sort = isset($sort) ? $sort : 'id';
		$sortDirection = $request->getUserVar('sortDirection');
		$sortDirection = (isset($sortDirection) && ($sortDirection == SORT_DIRECTION_ASC || $sortDirection == SORT_DIRECTION_DESC)) ? $sortDirection : SORT_DIRECTION_ASC;

Note that multiple submissions page displays are handled here, not just the archives:

github.com

pkp/ojs/blob/ojs-2_4_6-0/pages/editor/EditorHandler.inc.php#L203-L220


		switch($page) {
			case 'submissionsUnassigned':
				$functionName = 'getEditorSubmissionsUnassigned';
				$helpTopicId = 'editorial.editorsRole.submissions.unassigned';
				break;
			case 'submissionsInEditing':
				$functionName = 'getEditorSubmissionsInEditing';
				$helpTopicId = 'editorial.editorsRole.submissions.inEditing';
				break;
			case 'submissionsArchives':
				$functionName = 'getEditorSubmissionsArchives';
				$helpTopicId = 'editorial.editorsRole.submissions.archives';
				break;
			default:
				$page = 'submissionsInReview';
				$functionName = 'getEditorSubmissionsInReview';
				$helpTopicId = 'editorial.editorsRole.submissions.inReview';
		}

If you don’t want the default sort to change for Unassigned, InReview, InEditing, etc., you will need to provide a conditional for your change.

alirezaaa · September 29, 2016, 2:07pm

Thankyou @ctgraham,
problem solved.

Alex_Protopopescu · January 26, 2018, 11:15am

Hello,

Any pointers on where I could find this for OJS 3?

Thank you!

Alex_Protopopescu · January 26, 2018, 11:31am

@ctgraham I found it, in case anybody else is interested, the relevant file is lib/pkp/classes/submission/SubmissionDAO.inc.php

I changed all the queries mentioned in this patch pkp/pkp-lib#2270 Sort submission lists by ID · pkp/pkp-lib@e2e1a0c · GitHub but instead of inserting the patch sorting option

. ' ORDER BY s.submission_id',

I put

. ' ORDER BY ps.date_published DESC',

Now my Archives page starts with the latest articles first. Thank you!

Edit: this was done on OJS 3.0.0