Cyrillic 'b' treated as 'enter' in keywords

Vasyl_Ostrovskyi · November 25, 2017, 3:32pm

Hi,

I observed a strange thing in OJS 3.1.0. When entering keywords on the submission metadata page, entering cyrillic letter ‘b’ (unicode 0431) is treated as ‘enter’, i.e., it starts a new item in the keywords list. Therefore, I cannot enter any keyword containing this letter. Any other letter is entered properly.

Is there a way to avoid this, e.g., switch off the ‘enter’ key starting a new item?

Thanks,
Vasyl

asmecher · November 26, 2017, 5:11am

Hi @Vasyl_Ostrovskyi,

This is a known issue with the third-party “tag-it” library – see Tag it plugin doesn't work with cyrillic 'б' letter · Issue #251 · aehlke/tag-it · GitHub for details.

Regards,
Alec Smecher
Public Knowledge Project Team

Vitaliy · November 26, 2017, 9:58am

As I can see, this issue never was fixed. Mostly, because of moving to the new library:

Ph_We · November 26, 2017, 10:20am

I’d support the topic starter. The issue is still really annoying.

Vitaliy · November 26, 2017, 10:51am

Theoretically, removing this line should work:

github.com

pkp/pkp-lib/blob/main/js/lib/jquery/plugins/jquery.tag-it.js#L244


    }
} else if (that.options.removeConfirmation) {
    that._lastTag().removeClass('remove ui-state-highlight');
}

// Comma/Space/Enter are all valid delimiters for new tags,
// except when there is an open quote or if setting allowSpaces = true.
// Tab will also create a tag, unless the tag input is empty,
// in which case it isn't caught.
if (
    (event.key === ',' && event.shiftKey === false) ||
    event.which === $.ui.keyCode.ENTER ||
    (
        event.which == $.ui.keyCode.TAB &&
        that.tagInput.val() !== ''
    ) ||
    (
        event.which == $.ui.keyCode.SPACE &&
        that.options.allowSpaces !== true &&
        (
            $.trim(that.tagInput.val()).replace( /^s*/, '' ).charAt(0) != '"' ||

But practically, I don’t see any effect. Also, I don’t see the link to tag-it js file on article’s metadata page. So can’t check javascript from the browser.
@asmecher, maybe you can explain why?

Vasyl_Ostrovskyi · November 26, 2017, 7:17pm

Wow, I found a very UGLY solution without patching any code.

Press CapsLock
Press shift+‘б’
It works!!!

asmecher · November 2, 2018, 9:33pm

See Resolve TagIt's keyword separator character interference (Arabic/Cyrillic) · Issue #4208 · pkp/pkp-lib · GitHub for a git entry to consider replacements for tag-it.

Regards,
Alec Smecher
Public Knowledge Project Team