CSS Upload problem

mpbraendle · September 17, 2015, 9:16am

CSS files can’t be uploaded on our OJS installation.

I’ve read http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=908 , but it does not provide a solution.
The problem is that with PHP 5.3, mime_content_type() has been removed and therefore the file type isn’t checked correctly.

Please provide a patch.

ctgraham · September 17, 2015, 12:29pm

First check your config.inc.php setting mime_database_path to ensure this file exists and is the best source for magic.mime on your system:

github.com

pkp/ojs/blob/ojs-stable-2_4_6/config.TEMPLATE.inc.php#L223



; Permissions mask for created files and directories
umask = 0022


;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; Fileinfo (MIME) Settings ;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;

[finfo]
mime_database_path = /etc/magic.mime


;;;;;;;;;;;;;;;;;;;;;
; Security Settings ;
;;;;;;;;;;;;;;;;;;;;;

[security]

; Force SSL connections site-wide
force_ssl = Off

In 2.4.6, String::mime_content_type() checks the deprecated mime_content_type() and upgrades to finfo() if mime_content_type is not available. If neither mime_content_type() nor finfo() is available, we fall back to the file command. Sometimes the filetype is truly ambiguous, such as in the case of CSS files, and so there is a set of hardcoded disambiguations to close out the function.

github.com

pkp/pkp-lib/blob/59f21d45665eb351454af5c9a0977c30656ee6e3/classes/core/String.inc.php#L375-L427


	function mime_content_type($filename, $suggestedExtension = '') {
		$result = null;
		if (function_exists('mime_content_type')) {
			$result = mime_content_type($filename);
			// mime_content_type appears to return a charset
			// (erroneously?) in recent versions of PHP5
			if (($i = strpos($result, ';')) !== false) {
				$result = trim(substr($result, 0, $i));
			}
		} elseif (function_exists('finfo_open')) {
			$fi =& Registry::get('fileInfo', true, null);
			if ($fi === null) {
				$fi = finfo_open(FILEINFO_MIME, Config::getVar('finfo', 'mime_database_path'));
			}
			if ($fi !== false) {
				$result = strtok(finfo_file($fi, $filename), ' ;');
			}
		}

		// Fall back on an external "file" tool

This file has been truncated. show original