Bug with getFullName() on null error in OJS 3.5.0-1

Hi,

I think you have some bug in 3.5.0-1 that is connected with disabled users. I got this error:

Error: Call to a member function getFullName() on null in lib/pkp/classes/submission/reviewAssignment/DAO.php:156

when you try to access “Published” page or “Active submissions” page. I did debugging of the function like this:

public function fromRow(object $row): ReviewAssignment
{
    $reviewAssignment = parent::fromRow($row);
    error_log('Reviewer ID: ' . $reviewAssignment->getReviewerId());
    $reviewAssignment->setData(
        'reviewerFullName',
        Repo::user()->get($reviewAssignment->getReviewerId())->getFullName()
    );

    return $reviewAssignment;
}

so i got an ID of a user. If i enable that user then there is no error, everything works as expected.

Btw. more bugs to come.. :slight_smile:

Regards.

1 Like

Hi @orcalator, thanks for the bug report! I’ve filed this issue in GitHub and our team will look at it soon.