"Array" is the only option when reviewing after upgrade from 2.4.8 to 3.0

abalbuena · February 20, 2018, 7:55pm

After upgrading from 2.4.8 to 3.0, “Array” is the only option coming up as an answer when reviewing. Is there a way to fix this?

Thank you,

Angelo

vvucic · February 20, 2018, 10:47pm

Please post screenshot of error that you see. Which php version you use?

abalbuena · February 21, 2018, 1:55pm

Hi vvucic,

Below is the screenshot of what users are seeing in the review section. All answer options are set to “Array”

review

We are currently using PHP 5.3.

Thanks,

ajnyga · February 21, 2018, 2:03pm

github.com/pkp/pkp-lib

[OJS] Upgrade issue: custom review form items are displayed as "Array"

opened 07:35PM - 31 Aug 16 UTC

closed 10:32PM - 09 Jan 17 UTC

jmacgreg

Critical Issue

Custom review form items with multiple options - namely, radio button text, or c…heckbox text - are displayed as "Array" in the system. See attached screenshots for a comparison between OJS 2 and 3. They appear to be stored properly as arrays in the DB, eg. the following set of options from 1-5: a:5:{i:0;s:1:"1";i:1;s:1:"2";i:2;s:1:"3";i:3;s:1:"4";i:4;s:1:"5";} And if I create a new dropdown option, the content is displayed correctly (and the array looks the same in the DB). So I think this is just a display issue in OJS somehow. <img width="371" alt="ojs3dropdown" src="https://cloud.githubusercontent.com/assets/201446/18143387/cbb9c302-6f8f-11e6-9ce4-6afec785e53e.png"> <img width="323" alt="ojs2dropdown" src="https://cloud.githubusercontent.com/assets/201446/18143388/cbbaa830-6f8f-11e6-84fd-ba039f373fb8.png">

abalbuena · February 22, 2018, 2:04pm

Thanks ajnyga. It looks like the user in that post retried the upgrade. I already tried to re-do the upgrade in our TEST environment multiple times and the issue still occurs. Even updated PHP, still no luck.

Are there database scripts I can run to fix the issue?

ajnyga · February 22, 2018, 8:28pm

are you trying to upgrade to 3.0 not 3.1.0.1?

abalbuena · February 23, 2018, 4:34pm

Yes. I upgraded to version 3.0 from 2.4.8. I tried upgrading to 3.1.0.1 but had major issues. Upgrading to 3.0 was the only way I was able to get the upgrade to successfully complete.

ajnyga · February 23, 2018, 4:39pm

There are a lot of bugs in 3.0 so I would suggest that you tried upgrading.

The problem in this particular case is in the upgrade script at least in 3.0.0 and 3.0.1 so rerunning the upgrade will not help. The error itself is fairly easy to fix from the upgrade script however, see [OJS] Upgrade issue: custom review form items are displayed as "Array" · Issue #1782 · pkp/pkp-lib · GitHub

abalbuena · February 23, 2018, 6:19pm

I tried the fix and was able to upgrade successfully in my test environment. The issue I am having is that the upgrade in production was done a week back and users have already added new content to the journal. Is there anyway to fix this review piece without having to revert the database and lose data?

ajnyga · February 23, 2018, 6:39pm

@bozana knows best if there is a fix when upgrading from 3.0 to 3.1 for this issue.

Alternatively, you could of course try modifying the database. Maybe create a similar form in test environment and see how it is saved to the database, and then try to modify the existing form in the production journal accordingly. But I am not sure if there are possible problems hidden in the solution.

bozana · February 26, 2018, 10:13am

Hi @abalbuena

Hmmm…

I assume that the old review form elements have not changed since upgrade of the production system – they should never change because the old responses are bind to it and would not work any more.

Were those old review forms used in the meantime (after the production upgrade)? Could they be used at all, when the DB entries were wrong?
Have maybe new review forms been created and used, since production upgrade?

If the old review forms were not used and new forms not created, you could probably apply that function fixReviewForms again.
If the old review forms were used, I have no idea what is the result of it, how the entries in the DB look like. Could you in this case provide an example of how the entries in the DB table review_form_element_settings and review_form_responses look like: for the old entries before the upgrade and for the new entries after the upgrade?
If new forms and elements have been created and used after the upgrade, could you tell till which review_form_element_id were the old review forms? – so that that fix can be applied only for review_form_element_ids < that number.

Best,
Bozana

abalbuena · February 27, 2018, 6:18pm

Hi All,

The journal manager was able to recreate the review templates. Everything is good now.

Thank you