Add item, Sidebar management OJS 3.1

vvucic · October 30, 2017, 2:05pm

When I wanted to check Sidebar managemnt in newly created journal in OJS 3.1 I noticed that there are I guess, more than needed Add Item options. See screenshot in attach.

Thanks add-item

Thanks

simonmitternacht · January 25, 2018, 12:37pm

Hi,
We have a similar problem with OJS 3.1 upgraded from 2.4.8. Three “Add item” links, nothing happens if you click them (no requests are sent). They don’t disappear after clearing all caches.

Could it be that, since this is an upgraded install, there are some plugins registered that don’t exist for 3.1 or aren’t installed that cause problems?

Simon

vvucic · January 25, 2018, 2:12pm

I reinstalled and it worked well. I suggest that you should increase in php.ini execution time, RAM allocated to script so OJS can install properly. It seems to me that it happens that it says sometimes that it is installed although it is not completely OK.
Please delete all files in that folder if that is fresh installation and do install again.

If it is upgrade please use backup copy and make another in any case.

simonmitternacht · January 25, 2018, 2:32pm

I doubt that that is the problem, unfortunately. I upgraded from terminal, so I got verification that the install was complete.

vvucic · January 25, 2018, 2:37pm

I have had that verification too, but when I have done clean install again the problem disappeared.

asmecher · January 26, 2018, 1:22am

Hi all,

Try manually flushing your cache – in particular, deleting cache/*.css and cache/t_compile/*.php – then do a hard reload on your browser.

Regards,
Alec Smecher
Public Knowledge Project Team

simonmitternacht · January 26, 2018, 9:11am

Hi @asmecher,
That didn’t help either unfortunately.
Simon

simonmitternacht · January 26, 2018, 9:15am

I get several instances of the same two warnings when I load this page:

PHP Warning:  Illegal string offset 'nb_NO' in .../lib/pkp/classes/core/DataObject.inc.php on line 133, referer: https://.../index.php/index/admin/settings
PHP Warning:  Cannot use a scalar value as an array in .../lib/pkp/classes/core/DataObject.inc.php on line 133, referer: https://.../index.php/index/admin/settings

Not sure if it could be related.

ajnyga · January 26, 2018, 10:42am

Hi,

There are these two changes in the master branch that do not seem to be in the 3.1. release. Making these changes removes the three “Add items” links from the listbuilder.

github.com

pkp/pkp-lib/blob/main/classes/controllers/listbuilder/ListbuilderHandler.inc.php#L52-L55


/**
 * @copydoc GridHandler::initialize
 *
 * @param null|mixed $args

https://github.com/pkp/pkp-lib/blob/master/controllers/listbuilder/settings/BlockPluginsListbuilderHandler.inc.php#L68-L73

edit: and also:

github.com

pkp/pkp-lib/blob/main/classes/controllers/listbuilder/ListbuilderHandler.inc.php#L321-L328


        $changes[$column] = $value;
    }
}

// $changes should now contain e.g.:
// array ('localizedColumnName' => array('en_US' => 'englishValue'),
// 'nonLocalizedColumnName' => 'someNonLocalizedValue');
if (is_null($rowId)) {

Basically this commit: pkp/pkp-lib#2960 Remove Add Item action from sidebar grid · pkp/pkp-lib@522f110 · GitHub

simonmitternacht · January 26, 2018, 2:04pm

Thank you! I cherry-picked that commit into our fork and it solved the problem.

Simon

Sulthan90 · March 16, 2018, 1:38pm

Thank you that worked fine for me.