Review_request_remind_auto

marchitelli · October 17, 2016, 12:24pm

Hello,
it seems that when OJS 2.4.8 send the automated review request remind is using the email template REVIEW_REMIND_AUTO instead of REVIEW_REQUEST_REMIND_AUTO

Anyone can riproduce this issue?

Thanks,
andrea

asmecher · October 19, 2016, 6:50pm

Hi @marchitelli,

Is this for OJS 2.4.8 (a.k.a. OJS 2.4.8-0), or OJS 2.4.8-1?

Regards,
Alec Smecher
Public Knowledge Project Team

marchitelli · October 20, 2016, 5:14am

It is for 2.4.8 (not tested on 2.4.8-1)

asmecher · October 21, 2016, 8:29pm

Hi @marchitelli,

Glancing over the code, it seems OK; are you judging by the email contents? Ensure that you’ve differentiated not only REVIEW_REMIND_AUTO from REVIEW_REQUEST_REMIND_AUTO, but also REVIEW_REMIND_AUTO from REVIEW_REQUEST_REMIND_AUTO (the latter two being used when one-click reviewer access is enabled).

Regards,
Alec Smecher
Public Knowledge Project Team

fgnievinski · July 2, 2020, 7:09pm

confirmed:

github.com/pkp/pkp-lib

v2: REVIEW_REQUEST_REMIND_AUTO* should be different than REVIEW_REQUEST in translations too

opened 04:48PM - 18 Jun 20 UTC

closed 09:43AM - 01 Jul 20 UTC

fgnievinski

email reminders REVIEW_REQUEST_REMIND_AUTO (and *_ONECLICK) were split from REVI…EW_REQUEST, as per issues #562 and #1054. initially, the email content was simply copied as is. later, it was adapted in English and for v3 only: https://github.com/pkp/omp/commit/5f145844ec60f1c841caea8690004c9dd79d3dae then I backported the adaptation in English from v3 to v2: https://github.com/pkp/ojs/pull/2502 unfortunately, the translations of REVIEW_REQUEST_REMIND_AUTO* are still identical to those of REVIEW_REQUEST in most or all other languages for v2, e.g.: https://github.com/pkp/ojs/blob/ojs-dev-2_4/locale/pt_BR/emailTemplates.xml eventually, the adaptation was done in v3, e.g: https://github.com/pkp/ojs/blob/stable-3_2_1/locale/pt_BR/emails.po now, ideally they'd be backported to v2.

it was fixed in English only,
translations are pending.

FGN