hi Alec,
Yes, the “review_round_files” table still exists in my database. Please see attachment.
thanks
Hi @Ptran,
I think that is the issue. The review_round_files table should not exist in an OJS 2.4.8 installation – either it’s in your database dump for some reason (and shouldn’t be), or you’re not completely dropping and re-creating your database per the first step of this post.
Regards,
Alec Smecher
Public Knowledge Project Team
hi Alec,
I checked my original database from my OJS2.4.8 installation and " review_round_files" table is still exist in it. What I should be doing to fix this major upgrade issue? Since my OJS 2.4.8 is running as normal for couple years already.
thanks
Hi @Ptran,
Hmm, review_round_files should not exist in a 2.4.8 database. Are you sure that backup wasn’t already the result of a failed upgrade?
Regards,
Alec Smecher
Public Knowledge Project Team
hi Alec,
I got my OJS 2.4.8 version running for few years now. I’m sure that backup wasn’t already the result of a failed upgrade. I got it directly from my live database server. I triple checked live database and it does contain “review_round_files” . So i guess some where along the line back in 2014, when the upgraded from 2.4.6 to 2.4.8 happened, it created this error ?
Look like I’m in deep trouble, is there anyway to fix this problem without any complications?
Please help !! much apreciated !!
Hi @Ptran,
The quickest thing to do would probably be to DROP that table after loading your backup and before running the upgrade script. But if you’re not sure where the table came from, it’ll be hard to know if something else was affected by the same issue.
Regards,
Alec Smecher
Public Knowledge Project Team
hi Alec,
I restart the whole process again as your suggestion.
1. Drop the whole database then re-created a new one.
2. Import from backup to new empty database.
3. Drop “review_round_files” table .
4. Run the upgrade script.
And I got the following errors:
[pre-install]
[load: upgrade.xml]
[version: 3.1.0.1]
[code: Installer Installer::syncSeriesAssocType]
[data: dbscripts/xml/upgrade/2.4.0_preupdate_usageStatistics.xml (skipped)]
[data: dbscripts/xml/upgrade/2.4.0_preupdate_usageStatistics2.xml (skipped)]
[code: Installer Installer::removeReviewEntries]
[data: dbscripts/xml/upgrade/3.0.0_preupdate.xml]
[data: dbscripts/xml/upgrade/3.0.0_adaptTimedViews.xml (skipped)]
[data: dbscripts/xml/upgrade/3.0.0_adaptReferrals.xml]
[data: dbscripts/xml/upgrade/3.0.0_adaptBooksForReview.xml]
[data: dbscripts/xml/upgrade/remove_timed_views_bots.xml (skipped)]
[data: dbscripts/xml/upgrade/3.0.0_preupdate_commentsToEditor.xml (skipped)]
[code: Installer Installer::concatenateIntoAbout]
[code: Installer Installer::concatenateIntoMasthead]
[data: dbscripts/xml/upgrade/3.1.0_preupdate_review_assignments.xml]
[data: dbscripts/xml/upgrade/3.1.0_preupdate_notes.xml]
[data: dbscripts/xml/upgrade/3.1.0_preupdate_payments.xml]
[schema: lib/pkp/xml/schema/common.xml]
[schema: lib/pkp/xml/schema/log.xml]
[schema: lib/pkp/xml/schema/announcements.xml]
[schema: lib/pkp/xml/schema/scheduledTasks.xml]
[schema: lib/pkp/xml/schema/temporaryFiles.xml]
[schema: lib/pkp/xml/schema/metadata.xml]
[schema: lib/pkp/xml/schema/reviews.xml]
[schema: lib/pkp/xml/schema/reviewForms.xml]
[schema: lib/pkp/xml/schema/controlledVocab.xml]
[schema: lib/pkp/xml/schema/submissions.xml]
[schema: lib/pkp/xml/schema/submissionFiles.xml]
[schema: lib/pkp/xml/schema/notes.xml]
[schema: lib/pkp/xml/schema/views.xml]
[schema: lib/pkp/xml/schema/genres.xml]
[schema: lib/pkp/xml/schema/tombstone.xml]
[schema: lib/pkp/xml/schema/rolesAndUserGroups.xml]
[schema: lib/pkp/xml/schema/metrics.xml]
[schema: lib/pkp/xml/schema/views.xml]
[schema: lib/pkp/xml/schema/libraryFiles.xml]
[schema: lib/pkp/xml/schema/navigationMenus.xml]
[schema: dbscripts/xml/ojs_schema.xml]
[data: dbscripts/xml/indexes.xml]
[code: Installer Installer::migrateCounterPluginUsageStatistics (skipped)]
[code: Installer Installer::migrateTimedViewsUsageStatistics (skipped)]
[code: Installer Installer::migrateDefaultUsageStatistics (skipped)]
[data: dbscripts/xml/upgrade/2.4.0_postUsageStatsMigration.xml (skipped)]
[data: dbscripts/xml/upgrade/2.4.0_postUsageStatsMigration2.xml (skipped)]
[data: dbscripts/xml/upgrade/2.4.0_postCounterMigration.xml (skipped)]
[data: dbscripts/xml/upgrade/2.4.0_postTimedViewsMigration.xml (skipped)]
[data: dbscripts/xml/upgrade/3.0.0_change_assoc_type.xml]
[data: dbscripts/xml/upgrade/3.0.0_change_assoc_type_metrics.xml]
[data: dbscripts/xml/upgrade/3.0.0_settings.xml]
[code: Installer Installer::installDefaultGenres]
[code: Installer Installer::migrateArticleMetadata]
[data: dbscripts/xml/upgrade/3.0.0_update.xml]
[code: Installer Installer::clearDataCache]
[code: Installer Installer::migrateUserRoles]
[code: Installer Installer::fixReviewForms]
[code: Installer Installer::htmlifyEmailTemplates]
[note: docs/release-notes/README-BEACON]
[code: Installer Installer::installEmailTemplate]
[code: Installer Installer::installEmailTemplate]
[code: Installer Installer::installEmailTemplate]
[code: Installer Installer::installEmailTemplate]
[code: Installer Installer::installEmailTemplate]
[code: Installer Installer::installEmailTemplate]
[data: dbscripts/xml/upgrade/3.0.0_scheduledTasks.xml]
[code: Installer Installer::localizeCustomBlockSettings]
[code: Installer Installer::convertEditorDecisionNotes]
[code: Installer Installer::convertQueries]
[code: Installer Installer::migrateFiles]
[code: Installer Installer::convertSupplementaryFiles]
DB Error: Duplicate entry '2--old-supp-id' for key 'submission_file_settings_pkey'
Stack Trace:
File: /opt/rh/httpd24/root/var/www/ojs/classes/install/Upgrade.inc.php line 1467Function: DAO->update("INSERT INTO submission_file_settings (file_id, setting_name, set...", Array (4))
File: /opt/rh/httpd24/root/var/www/ojs/lib/pkp/classes/install/Installer.inc.php line 415
Function: Upgrade->convertSupplementaryFiles(Object(Upgrade), Array(1))
File: /opt/rh/httpd24/root/var/www/ojs/lib/pkp/classes/install/Installer.inc.php line 265
Function: Installer->executeAction(Array(3))
File: /opt/rh/httpd24/root/var/www/ojs/lib/pkp/classes/install/Installer.inc.php line 186
Function: Installer->executeInstaller()
File: /opt/rh/httpd24/root/var/www/ojs/lib/pkp/classes/cliTool/UpgradeTool.inc.php line 88
Function: Installer->execute()
File: /opt/rh/httpd24/root/var/www/ojs/lib/pkp/classes/cliTool/UpgradeTool.inc.php line 64
Function: UpgradeTool->upgrade()
File: /opt/rh/httpd24/root/var/www/ojs/tools/upgrade.php line 34
Function: UpgradeTool->execute()
Should I drop “Submission_file_settings” table as well ? or there is another way around?
Please advise, thanks so much !!
Hi @Ptran,
Yes, submission_file_settings should not exist in an OJS 2.4.8 backup.
The tables that should exist are listed in dbscripts/xml/ojs_schema.xml and lib/pkp/xml/schema/*.xml.
Regards,
Alec Smecher
Public Knowledge Project Team
hi Alec,
Finally !! I got my OJS upgraded to version 3.1.0-1 successfully ! thanks to all your help and support!
However, there are still few glitches that I need to find out why. I begin with the upgrade process by starting from v2.4.8 to v3.0.2.
- Drop the whole database, re-created a new one then import from backup to the new empty database.
- Drop 2 tables " review_round_files and submission_file_settings" in mysql database.
- Run the upgrade script.
The upgrade went fine with a few php warning errors. However, I logged back into mysql database to check and found out the 2 tables " review_round_files and submission_file_settings" got re-created again in the database.
This isn’t normal, isn’t it ? I thought those 2 tables shouldn’t not be exist in the database after the new upgraded.
Anyways, I continue my upgrade process from v3.02 to v3.1.0-1.
I repeat the same steps 1-3 above. The upgrade also went to successful with couple warnings but those 2 tables got re-created again for the second time.
I’m wondering what is wrong? I’m not sure what step that I missed to avoid for future upgrade issues.
Please advise
Hi @Ptran,
The tables review_round_files and submission_file_settings should exist in an OJS 3.x installation, but should not exist in an OJS 2.x installation. The upgrade scripts take care of creating and populating them, and the errors you were encountering were being caused by the tables’ unexpected existence in your 2.x backup.
Regards,
Alec Smecher
Public Knowledge Project Team