[OJS 3.2.4.1] Readers can't view pdfs

asmecher · March 10, 2022, 7:11pm

Hi all,

@diegomejia07, this is caused by an inconsistency in the database. The redirect to search is happening here:

pkp/ojs/blob/stable-3_3_0/pages/article/ArticleHandler.inc.php#L542

      
        
            
            
					if (!isset($galleyId) || $galleyId) {
            						if (!Validation::isLoggedIn()) {
            							Validation::redirectLogin('reader.subscriptionRequiredLoginText');
            						}
            						$request->redirect(null, 'about', 'subscriptions');
            					}
            				}
            			}
            		} else {
            			$request->redirect(null, 'search');
            		}
            		return true;
            	}
            
            
	/**
            	 * Set up the template. (Load required locale components.)
            	 * @param $request PKPRequest
            	 */
            	function setupTemplate($request) {
            		parent::setupTemplate($request);

It’s caused by falling through this condition:

github.com

pkp/ojs/blob/stable-3_3_0/pages/article/ArticleHandler.inc.php#L471

      
        
            		$user = $request->getUser();
            		$userId = $user?$user->getId():0;
            
            
		// If this is an editorial user who can view unpublished/unscheduled
            		// articles, bypass further validation. Likewise for its author.
            		if ($submission && $issueAction->allowedPrePublicationAccess($context, $submission, $user)) {
            			return true;
            		}
            
            
		// Make sure the reader has rights to view the article/issue.
            		if ($issue && $issue->getPublished() && $submission->getStatus() == STATUS_PUBLISHED) {
            			$subscriptionRequired = $issueAction->subscriptionRequired($issue, $context);
            			$isSubscribedDomain = $issueAction->subscribedDomain($request, $context, $issue->getId(), $submission->getId());
            
            
			// Check if login is required for viewing.
            			if (!$isSubscribedDomain && !Validation::isLoggedIn() && $context->getData('restrictArticleAccess') && isset($galleyId) && $galleyId) {
            				Validation::redirectLogin();
            			}
            
            
			// bypass all validation if subscription based on domain or ip is valid
            			// or if the user is just requesting the abstract

My guess is that the status column in the submissions table does not match the value in the publications table. Try:

SELECT p.status, s.status FROM submissions s JOIN publications p ON (s.current_publication_id = p.publication_id) WHERE s.submission_id = 17;

Regards,
Alec Smecher
Public Knowledge Project Team