OJS 3 Error logs

knjigor · September 21, 2016, 8:15am

Our error log is full of errors:

 [Wed Sep 21 10:07:14.753594 2016] [fcgid:warn] [pid 28443] [client 192.168.131.1:62792] mod_fcgid: stderr: PHP Warning:  file_exists(): open_basedir restriction in effect. File(/lib/pkp/js/lib/jquery/plugins/validate/localization/messages_en_US.js) is not within the allowed path(s): (/var/www/clients/client0/web6/web:/var/www/clients/client0/web6/private:/var/www/clients/client0/web6/tmp:/var/www/migracija.ff.uns.ac.rs/web:/srv/www/migracija.ff.uns.ac.rs/web:/usr/share/php5:/usr/share/php:/tmp:/usr/share/phpmyadmin:/etc/phpmyadmin:/var/lib/phpmyadmin) in /var/www/clients/client0/web6/web/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 567, referer: http://migracija.ff.uns.ac.rs/index.php/gff/management/importexport/plugin/NativeImportExportPlugin
 [Wed Sep 21 10:07:14.753597 2016] [fcgid:warn] [pid 28443] [client 192.168.131.1:62792] mod_fcgid: stderr: PHP Warning:  file_exists(): open_basedir restriction in effect. File(/lib/pkp/js/lib/jquery/plugins/validate/localization/messages_en.js) is not within the allowed path(s): (/var/www/clients/client0/web6/web:/var/www/clients/client0/web6/private:/var/www/clients/client0/web6/tmp:/var/www/migracija.ff.uns.ac.rs/web:/srv/www/migracija.ff.uns.ac.rs/web:/usr/share/php5:/usr/share/php:/tmp:/usr/share/phpmyadmin:/etc/phpmyadmin:/var/lib/phpmyadmin) in /var/www/clients/client0/web6/web/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 567, referer: http://migracija.ff.uns.ac.rs/index.php/gff/management/importexport/plugin/NativeImportExportPlugin
 [Wed Sep 21 10:07:14.753600 2016] [fcgid:warn] [pid 28443] [client 192.168.131.1:62792] mod_fcgid: stderr: PHP Warning:  file_exists(): open_basedir restriction in effect. File(/lib/pkp/lib/vendor/moxiecode/plupload/js/i18n/en_US.js) is not within the allowed path(s): (/var/www/clients/client0/web6/web:/var/www/clients/client0/web6/private:/var/www/clients/client0/web6/tmp:/var/www/migracija.ff.uns.ac.rs/web:/srv/www/migracija.ff.uns.ac.rs/web:/usr/share/php5:/usr/share/php:/tmp:/usr/share/phpmyadmin:/etc/phpmyadmin:/var/lib/phpmyadmin) in /var/www/clients/client0/web6/web/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 584, referer: http://migracija.ff.uns.ac.rs/index.php/gff/management/importexport/plugin/NativeImportExportPlugin
 [Wed Sep 21 10:07:14.753603 2016] [fcgid:warn] [pid 28443] [client 192.168.131.1:62792] mod_fcgid: stderr: PHP Warning:  file_exists(): open_basedir restriction in effect. File(/lib/pkp/lib/vendor/moxiecode/plupload/js/i18n/en.js) is not within the allowed path(s): (/var/www/clients/client0/web6/web:/var/www/clients/client0/web6/private:/var/www/clients/client0/web6/tmp:/var/www/migracija.ff.uns.ac.rs/web:/srv/www/migracija.ff.uns.ac.rs/web:/usr/share/php5:/usr/share/php:/tmp:/usr/share/phpmyadmin:/etc/phpmyadmin:/var/lib/phpmyadmin) in /var/www/clients/client0/web6/web/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 584, referer: http://migracija.ff.uns.ac.rs/index.php/gff/management/importexport/plugin/NativeImportExportPlugin
 [Wed Sep 21 10:07:14.753605 2016] [fcgid:warn] [pid 28443] [client 192.168.131.1:62792] mod_fcgid: stderr: PHP

Is there a way to get rid of them?

ctgraham · September 21, 2016, 12:45pm

This implies that the call $this->_request->getBasePath() is returning an empty string.

github.com

pkp/pkp-lib/blob/ojs-3_0_0-0/classes/template/PKPTemplateManager.inc.php#L548


				'header' => $header,
			);
		}
	}

	/**
	 * Register all files required by the core JavaScript library
	 */
	function registerJSLibrary() {

		$basePath = $this->_request->getBasePath();
		$baseUrl = $this->_request->getBaseUrl();
		$localeChecks = array(AppLocale::getLocale(), strtolower(substr(AppLocale::getLocale(), 0, 2)));

		// Common $args array used for all our core JS files
		$args = array(
			'priority' => STYLE_SEQUENCE_CORE,
			'contexts' => 'backend',
		);

		// Load jQuery validate separately because it can not be linted

Are you handy with PHP? Can you identify why the code isn’t picking up a valid directory path?

github.com

pkp/pkp-lib/blob/ojs-3_0_0-0/classes/core/PKPRequest.inc.php#L176-L209


	/**
	 * Get the base path of the request (excluding trailing slash).
	 * @return string
	 */
	function getBasePath() {
		$_this =& PKPRequest::_checkThis();

		if (!isset($_this->_basePath)) {
			// Strip the PHP filename off of the script's executed path
			// We expect the SCRIPT_NAME to look like /path/to/file.php
			// If the SCRIPT_NAME ends in /, assume this is the directory and the script's actual name
			// is masked as the DirectoryIndex
			// If the SCRIPT_NAME ends in neither / or .php, assume the the script's actual name is masked
			// and we need to avoid stripping the terminal directory
			$path = preg_replace('#/[^/]*$#', '', $_SERVER['SCRIPT_NAME'].(substr($_SERVER['SCRIPT_NAME'], -1) == '/' || preg_match('#.php$#i', $_SERVER['SCRIPT_NAME']) ? '' : '/'));

			// Encode charcters which need to be encoded in a URL.
			// Simply using rawurlencode() doesn't work because it
			// also encodes characters which are valid in a URL (i.e. @, $).
			$parts = explode('/', $path);

This file has been truncated. show original

Alternately, could you report what your $_SERVER['SCRIPT_NAME'] variable is defined as?

asmecher · September 21, 2016, 2:17pm

Hi all,

Note that we’ve seen this once or twice ourselves; I’ll look into it soon and post my results here.

Regards,
Alec Smecher
Public Knowledge Project Team

mfelczak · September 21, 2016, 10:04pm

Hi @ctgraham,

Confirming the above warnings on our servers as well.

It looks like $_SERVER[‘SCRIPT_NAME’] is set to ‘/index.php’ (on e.g. the main install page) and the call to PKPRequest::getBasePath is returning an empty string.

Cheers,
Michael

ctgraham · September 22, 2016, 12:07pm

If PKPRequest::getBaseUrl() were guaranteed to return either “” or a relative or absolute path terminated by a “/”, then other path constructions would be $baseUrl . ‘relative/path/to/include’. This, I think, makes more sense than prefixing the include path with a “/”:

github.com

pkp/pkp-lib/blob/ojs-3_0_0-0/classes/template/PKPTemplateManager.inc.php#L562


		// Common $args array used for all our core JS files
		$args = array(
			'priority' => STYLE_SEQUENCE_CORE,
			'contexts' => 'backend',
		);

		// Load jQuery validate separately because it can not be linted
		// properly by our build script
		$this->addJavaScript(
			'jqueryValidate',
			$baseUrl . '/lib/pkp/js/lib/jquery/plugins/validate/jquery.validate.min.js',
			$args
		);
		$localePath = '/lib/pkp/js/lib/jquery/plugins/validate/localization/messages_';
		foreach ($localeChecks as $localeCheck) {
			if (file_exists($basePath . $localePath . $localeCheck .'.js')) {
				$this->addJavaScript('jqueryValidateLocale', $baseUrl . $localePath . $localeCheck . '.js', $args);
			}
		}

		$this->addJavaScript(