Unable to confirm a review

eniocarboni · February 26, 2019, 4:57pm

OJS 3.1.1.2, PostgreSQL database, php 7.0.33.
As an editor I can not confirm a review.
In the “Reviewer” section of my “Round” 2, click on “Read Review” and then click on the “Confirm” button at the bottom.
The window closes and nothing happens, no javascript error from the Firefox console and no javascipt error.
What could cause this problem?
Screenshot_ojs

ajnyga · February 27, 2019, 5:58am

Can you access the php error log?

eniocarboni · February 27, 2019, 8:46am

Ooops! typo. I wanted to write “no javascript error from the Firefox console and no php error”.
Yes i can acess.
As you can see the problem concerns only the second reviewer.
As a further information, I say that this “Submission” has not been assigned to any “editor”.
Also when I click on “Confirm” in the Firefox console I see these calls.
Screenshot_ojs_console_js

ajnyga · February 27, 2019, 11:00am

It could be that moving forward a submission without an assigned editor will cause some other problems down the line, but I can not see this connected to that.

Just to make sure, do you have any browser plugins running? Have you tried to use another browser?

eniocarboni · February 27, 2019, 11:10am

Yes sure, I tried.
Even my clients of the publishing house and therefore the “editor” with different PCs have tried and we are all in different places.

eniocarboni · March 1, 2019, 10:51am

Any suggestions?
If someone considers it useful or would like more information, I could query the db to try to understand the problem.

eniocarboni · March 6, 2019, 2:44pm

From what I understand, seeing the source code, if no “section editor” or “editor” is assigned to the “Submission” then it is not possible to confirm the revision.
In fact, even if an unassigned “editor” click on the “Confirm” button related to the revision it is recorded as read in the “item_views” table but it is not recognized as valid because it is not associated with the “Submission”.
You can see the source code

github.com

pkp/pkp-lib/blob/ojs-3_1_1-2/controllers/grid/users/reviewer/ReviewerGridCellProvider.inc.php#L126..L132



		// Only attach actions to the actions column. The actions and status
		// columns share state values.
		$columnId = $column->getId();
		if ($columnId == 'actions') {
			switch($this->getCellState($row, $column)) {
				case REVIEW_ASSIGNMENT_STATUS_RESPONSE_OVERDUE:
				case REVIEW_ASSIGNMENT_STATUS_REVIEW_OVERDUE:
					import('lib.pkp.controllers.api.task.SendReminderLinkAction');
					return array(new SendReminderLinkAction($request, 'editor.review.reminder', $actionArgs));
				case REVIEW_ASSIGNMENT_STATUS_COMPLETE:
					import('lib.pkp.controllers.api.task.SendThankYouLinkAction');
					import('lib.pkp.controllers.review.linkAction.UnconsiderReviewLinkAction');
					return array(
						new SendThankYouLinkAction($request, 'editor.review.thankReviewer', $actionArgs),
						new UnconsiderReviewLinkAction($request, $reviewAssignment, $submission),
					);
				case REVIEW_ASSIGNMENT_STATUS_THANKED:
					import('lib.pkp.controllers.review.linkAction.UnconsiderReviewLinkAction');
					return array(new UnconsiderReviewLinkAction($request, $reviewAssignment, $submission));
				case REVIEW_ASSIGNMENT_STATUS_RECEIVED:

and here

github.com

pkp/pkp-lib/blob/ojs-3_1_1-2/classes/submission/reviewAssignment/ReviewAssignment.inc.php#L502..L555


				} else {
					return REVIEW_ASSIGNMENT_STATUS_ACCEPTED;
				}
			}
		} elseif ($this->getDateAcknowledged()) { // reviewer thanked...
			if ($this->getUnconsidered() == REVIEW_ASSIGNMENT_UNCONSIDERED) { // ...but review later unconsidered
				return REVIEW_ASSIGNMENT_STATUS_RECEIVED;
			}
			return REVIEW_ASSIGNMENT_STATUS_THANKED;
		} elseif ($this->getDateCompleted()) { // review submitted...
			if ($this->getUnconsidered() != REVIEW_ASSIGNMENT_UNCONSIDERED && $this->isRead()) { // ...and confirmed by an editor
				return REVIEW_ASSIGNMENT_STATUS_COMPLETE;
			}
			return REVIEW_ASSIGNMENT_STATUS_RECEIVED;
		}

		return REVIEW_ASSIGNMENT_STATUS_AWAITING_RESPONSE;
	}

	/**
	 * Determine whether an editorial user has read this review

I then solved by assigning a section editor.