Hello,
The review form works fine. It’s created with select, radio buttons and other elements.
But there is an issue, once the author opens the provided review form all provided data is displayed in one line! Without any breaks, it ignores all formatting and HTML elements!
The review is placed in
<div class="email_entry">
div element.
How it could be fixed?
Hi @Garant,
Could you provide more details, please? Such as what version you are working within (e.g. 3.3.0-14), as this is important for others to know in assisting you.
-Roger
PKP Team
Pardon me,
I was copy-pasting text and details with the current version has disappeared.
It’s 3.3.0.8
Hi @Garant,
I wasn’t able to replicate the problem here – but I imported the review contents into the email using the “+ Add Reviews to Email” button rather than copy/paste; I wonder if that might be part of the problem. Can you try using the “+ Add Reviews to Email” button instead to see if it resolves the issue?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi, @asmecher
But did you log in as an author?
Because this bug is visible to authors.
And could you tell me, where I could find the “+ Add Reviews to Email” button?
I’m logging as admin and Journal editor, but I don’t see it.
Also, the OJS was upgraded, here are the last three version entries:
3.3.0.8
3.2.1.3
2.4.8.3 and etc…
Thank you!
Hi @Garant,
Yes, I logged in as the author.
The “+ Add Reviews to Email” button should be in the modal that pops up when you record an editorial decision in the review stage, below the email composition window:
Regards,
Alec Smecher
Public Knowledge Project Team
Thank you Alec,
I will review this on a test environment I will write back.
As a review decision has been already recorded I am afraid that I could test it on a dev environment.
Hi, Alec
So I got the feedback from the journal section manager:
once he or admin logs in and presses “Review” button, the form is shown normally, as this:
But as he sends the review to a author through email, the author receives everything in one line, the same as the author logs in and sees review form in the system (my first post)
Hi @Garant,
Was the review sent to the author using copy/paste as you wrote before, or using the “+ Add Reviews To Email” button?
Thanks,
Alec Smecher
Public Knowledge Project Team
Yes, using the “+ Add Reviews To Email” button.
@isabellajon , thank you very much, but in the html output there are no any tags which could be formatted, as you see in my screenshot:
https://forum.pkp.sfu.ca/uploads/default/original/3X/c/8/c8bd7549f66ef4deb89c9fa07694d91fa580e3c6.png
the text is wrapped only in one div without any tags
Hi @Garant,
Have you customized the allowed_html setting in config.inc.php?
Regards,
Alec Smecher
Public Knowledge Project Team
Hi, Alec
I don’t know, does it was customized, as OJS was upgraded from 2.x versions, and there were a few maintainers during that period of time…
The current code is:
; Allowed HTML tags for fields that permit restricted HTML.
; For PHP 5.0.5 and greater, allowed attributes must be specified individually
; e.g. <img src|alt> to allow "src" and "alt" attributes. Unspecified
; attributes will be stripped. For PHP below 5.0.5 attributes may not be
; specified in this way.
allowed_html = "<a href|target> <em> <strong> <cite> <code>
<ul>
<ol>
<li>
<dl>
<dt>
<dd> <b> <i> <u> <img src|alt> <sup> <sub> <br>
<p>"
; Prevent VIM from attempting to highlight the rest of the config file
; with unclosed tags:
; </p>
</sub></sup></u></i></b></dd>
</dt>
</dl>
</li>
</ol>
</ul>
</code></cite></strong></em></a>
Hi @Garant,
I think that’s the problem. The format of that setting changed starting with OJS 3.0; see the config.TEMPLATE.inc.php template for information:
Regards,
Alec Smecher
Public Knowledge Project Team
Excellent, Alec!
It seems that it was the issue.
We are testing now. If there will be no additional issues - it will be the solution of the problem.
This topic was automatically closed after 18 days. New replies are no longer allowed.