[Solved] Questions about OJS 3.0.2


#14

What happens if you change the message text to something simpler? I mean something without those variables.

Edit:

Ok, so adding the author name variable there will break it. I do not know why.
{$submissionTitle}, {$contextName} and {$editorialContactSignature} work just fine. Try removing the authorName variable from the template and see what happens.

@asmecher probably knows why the authorName is not available there. Two suggestions to make this work better @asmecher:

  1. Even when a template has a variable that will not work, OJS should not return an empty template like it does now.
  2. Maybe we could have a list of available variables in the form that you use to create custom templates? The list could be hidden by default (a javascript toggle link + hidden div).

#15

Indeed, when removed the author name the template worked like a charm.

Thx for the efforts!


#16

Here is another variables that don’t work in notification (custom templates):
{$passwordResetUrl}
{$submissionUrl}


#17

Hi all,

I suspect there’s an error message, either in your browser console or your PHP error log, that will provide some more details on the problem.

Regards,
Alec Smecher
Public Knowledge Project Team


#18

If u can guide me how to get this log, i can gather it for you.


#19

Hi @Hugo_Melo,

See the FAQ for information about your PHP error log; for the browser console, Google your browser name and “error console” for instructions on how to find it.

Regards,
Alec Smecher
Public Knowledge Project Team


#20

Ok, here is what the chrome console is giving me when i choose a template with those variables:

image


#21

Hi @Hugo_Melo,

Thanks, that’s helpful. I’ve filed this for attention at https://github.com/pkp/pkp-lib/issues/2863.

Regards,
Alec Smecher
Public Knowledge Project Team


#22

I am having a problem I haven’t notice before.
When setting a reviewer to judge a paper, the deadline is completly wrong, even when its set correctly: Look:


Somehow, i think its related to the time settings on the config.php, but i have no clue how to fix it.
My config.php is this:

; Short and long date formats
date_format_trunc = “%d-%m”
date_format_short = “%d-%m-%Y”
date_format_long = “%B %e, %Y”
datetime_format_short = “%d-%m-%Y %I:%M %p”
datetime_format_long = “%B %e, %Y - %I:%M %p”
time_format = “%I:%M %p”

I don’t think the problem is in the server clock since the time is correctly showed on everywhere else:

Any ideas?


#23

Hi @Hugo_Melo,

I believe this is already filed at https://github.com/pkp/pkp-lib/issues/2689. I’ll link to your description from the bug entry.

Regards,
Alec Smecher
Public Knowledge Project Team


#24

According to the issue, if i turn my config.php back to original the problem will not happen?


#25

Hi @Hugo_Melo,

You can try that and see if it changes the behavior. However, I’ve just tried with OJS 3.1.0 and your date format setting and wasn’t able to reproduce the problem. The most helpful thing would be to…

  • confirm whether restoring the date setting solves the problem, and
  • confirm whether you’re able to reproduce this behavior in OJS 3.1.0, and
  • confirm whether the patch at https://github.com/pkp/pkp-lib/pull/2775 fixes the issue, either on 3.0.2 or on 3.1.0.

Regards,
Alec Smecher
Public Knowledge Project Team


#26

Okay. Getting the time in config.php back to original turned off the error.

I will now update do 3.1 and change time to Brazilian again and see if the error is back, and report here for you.
Thanks for the patience.


#27

Hi @Hugo_Melo,

One of our developers has put together a patch for the Javascript issue you described earlier. Could you test this change and report back whether or not it corrects the issue?

Regards,
Alec Smecher
Public Knowledge Project Team


#28

Alright, I am about to try this, but i need more info.
For example, in what file should i put this code? At what position?
I am already at OJS 3.1, should I try this piece of code? I am waiting for receiving any article for evaluation to test if the error still in ojs 3.1.


#29

Hi @Hugo_Melo,

The best way to apply the change is using the standard “patch” tool. You can read more about patch files e.g. here: https://stackoverflow.com/questions/987372/what-is-the-format-of-a-patch-file

Regards,
Alec Smecher
Public Knowledge Project Team


#30

Man, i’ve read it several times, but I think it is too much for my experties.
I couldn’t figure out how to “patch” that piece of code.
I will test the same error in 3.1 to see if it continues though, and let you know.


#31

Hi @Hugo_Melo,

In brief, edit lib/pkp/js/classes/TinyMCEHelper.js; find the lines that the patch describes starting with a - and remove them; and add in their place the lines the patch describes with a +. (Omit the - and +, of course.)

Note that you’ll nave to turn off minification in your config.inc.php for these files to be used instead, and you’ll need to reload in your browser.

Regards,
Alec Smecher
Public Knowledge Project Team


#32

OKay. I am here to show you that the error persists in 3.1, and it is even worse, the date is now empty:

I will try to insert the code and let you guys know about it.

However, i am having a more annoying trouble now. The email models i have made to notify authors, isn’t showing anymore. Tried to delete and create it again, but still not showing, and interesting it always create as a Signture Manager, what didn’t happen in 3.0.2:

This is what I am getting:

When i turn the notifications on, the page is not even loading:

Strict Standards: Declaration of DRIVERDAO::setOAI() should be compatible with PKPOAIDAO::setOAI($oai) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php on line 19

Strict Standards: Declaration of PKPWorkflowHandler::initialize() should be compatible with PKPHandler::initialize($request) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/pages/workflow/PKPWorkflowHandler.inc.php on line 506

Warning: Cannot modify header information - headers already sent by (output started at /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php:19) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 855

Warning: Cannot modify header information - headers already sent by (output started at /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/plugins/generic/driver/DRIVERDAO.inc.php:19) in /home/dpgpsifp/psicodebate.dpgpsifpm.com.br/lib/pkp/classes/template/PKPTemplateManager.inc.php on line 856


#33

The code didn’t work, it is showing an error now:


Big problem with DRIVER plugin