Searchbox block on version 2.4.8-2 with wrong url

paulo-graca · August 7, 2017, 11:47am

the file:

pkp/ojs/blob/ojs-stable-2_4_8/plugins/blocks/navigation/block.tpl

{**
 * plugins/blocks/navigation/block.tpl
 *
 * Copyright (c) 2013-2019 Simon Fraser University
 * Copyright (c) 2003-2019 John Willinsky
 * Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.
 *
 * Common site sidebar menu -- navigation links.
 *
 *}
{if !$currentJournal || $currentJournal->getSetting('publishingMode') != $smarty.const.PUBLISHING_MODE_NONE}
<div class="block" id="sidebarNavigation">
	<span class="blockTitle">{translate key="plugins.block.navigation.journalContent"}</span>

	{url|assign:"searchFormUrl" page="search" op="search" escape=false}
	{$searchFormUrl|parse_url:$smarty.const.PHP_URL_QUERY|parse_str:$formUrlParameters}
	<form id="simpleSearchForm" action="{$searchFormUrl|strtok:"?"|escape}">
		{foreach from=$formUrlParameters key=paramKey item=paramValue}
			<input type="hidden" name="{$paramKey|escape}" value="{$paramValue|escape}"/>
		{/foreach}

This file has been truncated. show original

at the 15th line, you will find:
{url|assign:"searchFormUrl" page="search" op="search" escape=false}

but in the 2.4.8-2 (*.tar.gz) released version you will find the following:
{url|assign:"searchFormUrl" op="search" escape=false}

this will result in an error if you try to search, using this block, in other page different that the “search” page.

ctgraham · August 8, 2017, 12:43pm

This issue is documented here:
https://github.com/pkp/pkp-lib/issues/2442

The fix is scheduled against 2.4.9; you can use the 2.4.8 stable branch of GitHub for access to the fix before it is released.