Removing journal signatures from reviewer response emails version 3.0.1.0

Feature Requests
1

Hi,

It appears that Journal Signatures are added to all the email templates, even to ones which are sent from the reviewers like REVIEW_CONFIRM and REVIEW_DECLINE.

The fix for that would be:
lib/pkp/classes/submission/reviewer/ReviewerAction.inc.php
function getResponseEmail:

$email = new SubmissionMailTemplate($submission,$decline?'REVIEW_DECLINE':'REVIEW_CONFIRM');

TO:

$email = new SubmissionMailTemplate($submission,$decline?'REVIEW_DECLINE':'REVIEW_CONFIRM', null, null, false);

And

lib/pkp/classes/mail/MailTemplate.inc.php
function send()

Make adding the signature conditional:

if($this->includeSignature){
		if (strstr($this->getBody(), '{$templateSignature}') === false) {
			$this->setBody($this->getBody() . "<br/>" . $signature);
		} else {
				$this->setBody(str_replace('{$templateSignature}', $signature, $this->getBody()));
		}
}

Thanks

2

Hi @salehig,

What version of OJS are you using? (Please include this with your posts.)

Regards,
Alec Smecher
Public Knowledge Project Team

3

Hi @asmecher. We are running version 3.0.1.0. I checked the code is the same in 3.1.0.

4

Hi @salehig,

This is by design – the footer doesn’t indicate the user’s affiliation with e.g. managing the journal, just the means by which the message was delivered.

The includeSignature parameter is intended to define whether the user’s signature – not the journal’s – is included. Adding the new conditional confuses the two.

Regards,
Alec Smecher
Public Knowledge Project Team