Parent custom themes problem OMP 3.4

Hi all

I’ve discovered a problem regarding parent custom themes. I’ve had to comment out from line 159 on in ThemePlugin.php to make it work.

    /*    // Update colour based on theme option
        if ($this->getOption('baseColour') !== '#1E6292') {
            $additionalLessVariables[] = '@bg-base:' . $this->getOption('baseColour') . ';';
            if (!$this->isColourDark($this->getOption('baseColour'))) {
                $additionalLessVariables[] = '@text-bg-base:rgba(0,0,0,0.84);';
                $additionalLessVariables[] = '@bg-base-border-color:rgba(0,0,0,0.2);';
            }
        } */

php error was as follows:

[Mon Jul 03 12:48:51.611346 2023] [php:error] [pid 11380:tid 1852] [client ::1:53508] PHP Fatal error: Uncaught TypeError: PKP\\plugins\\ThemePlugin::isColourDark(): Argument #1 ($color) must be of type string, null given, called in C:\\xampp\\htdocs\\omp-3.4.0-0\\plugins\\themes\\centerbop\\BopcenterThemePlugin.php on line 161 and defined in C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\plugins\\ThemePlugin.php:873\nStack trace:\n#0 C:\\xampp\\htdocs\\omp-3.4.0-0\\plugins\\themes\\centerbop\\BopcenterThemePlugin.php(161): PKP\\plugins\\ThemePlugin->isColourDark(NULL)\n#1 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\components\\forms\\context\\PKPThemeForm.php(89): APP\\plugins\\themes\\centerbop\\BopcenterThemePlugin->init()\n#2 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\pages\\management\\ManagementHandler.php(201): PKP\\components\\forms\\context\\PKPThemeForm->__construct('http://localhos...', Array, Object(APP\\press\\Press))\n#3 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\pages\\management\\ManagementHandler.php(90): PKP\\pages\\management\\ManagementHandler->website(Array, Object(APP\\core\\Request))\n#4 [internal function]: PKP\\pages\\management\\ManagementHandler->settings(Array, Object(APP\\core\\Request))\n#5 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\core\\PKPRouter.php(334): call_user_func(Array, Array, Object(APP\\core\\Request))\n#6 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\core\\PKPPageRouter.php(277): PKP\\core\\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\\core\\Request), Array, false)\n#7 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\core\\Dispatcher.php(165): PKP\\core\\PKPPageRouter->route(Object(APP\\core\\Request))\n#8 C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\core\\PKPApplication.php(373): PKP\\core\\Dispatcher->dispatch(Object(APP\\core\\Request))\n#9 C:\\xampp\\htdocs\\omp-3.4.0-0\\index.php(21): PKP\\core\\PKPApplication->execute()\n#10 {main}\n thrown in C:\\xampp\\htdocs\\omp-3.4.0-0\\lib\\pkp\\classes\\plugins\\ThemePlugin.php on line 873, referer: http://localhost/omp-3.4.0-0/index.php/TP/submissions