OMP undefined STATUS_PUBLISHED error on Press delete

Software Support
1

Hello everyone!
in OMP 3.2.1-2 I have an error if I try to delete a press at the page:
https://<DNS-NAME>/index.php/index/admin/contexts

The error is:
invalid input syntax for integer: "STATUS_PUBLISHED" Query: select "s".* from "submissions" as "s" where "s"."context_id" = ? and "s"."status" in (?) group by "s"."submission_id" order by "s"."date_submitted" desc in /lib/pkp/classes/db/DAO.inc.php

The fatal error is caused by this:
PHP Warning: Use of undefined constant STATUS_PUBLISHED - assumed STATUS_PUBLISHED'

Following the hint I’ve found on:

I’ve added this workaround code at line 83 and 108 of ‘classes/publicationFormat/PublicationFormatTombstoneManager.inc.php’:
import('lib.pkp.classes.submission.PKPSubmission');

Do you already know this bug? Do you have a better suggestion to correct it?
Thanks

2

Hi @sourcedump,

Good catch! Could you file this in github as a new issue (link to the other if you like) and submit a pull request with the change you propose?

Thanks,
Alec Smecher
Public Knowledge Project Team

3

Sure!
Should I make the pull request on the version we are using ( stable-3_2_1 branch ) or on the master branch?

4

Hi @sourcedump,

Generally we’re happiest to have a pull request to the latest stable branch (that’s currently stable-3_3_0); we can take care of cherry-picking forward from there to main. However, if you’re working with stable-3_2_1, that’s fine too!

Thanks,
Alec Smecher
Public Knowledge Project Team

5

Hello @asmecher ,
I’ve made the PR for the ‘stable-3_2_1’ branch. here the links:

6

Hi @sourcedump,

Thanks, all merged and cherry-picked forward for the next release!

Regards,
Alec Smecher
Public Knowledge Project Team