Hi everyone,
While testing OMP 3.5, I noticed a small UI issue on the public monograph page. It is not critical, but I thought it would be worth reporting.
Describe the issue or problem
When a monograph has no references at all, the “References” heading is still displayed on the public catalog page, with an empty section underneath it.
I tested this with a publication where no references had ever been entered, so this does not appear to be related to references being added and later deleted.
This seems very similar to an issue that was previously reported and fixed in OJS:
- pkp/pkp-lib#12184 – The “references” section for an article shows even when none given
- pkp/ojs#5249 – Fix condition check for parsed citations in template
In the OJS issue, the cause was that the citations variable is a LazyCollection, which evaluates as true even when it contains no items. The OJS template was therefore changed to check the number of citations instead.
Looking at the current OMP 3.5 template, it seems that OMP may still be using the previous type of condition:
OMP stable-3_5_0 – monograph_full.tpl
{if $citations || (string) $publication->getData(‘citationsRaw’)}
so I wondered whether the same fix may simply not have been applied to the OMP template.
Steps to reproduce
- Create a monograph in OMP.
- Do not enter anything in the References field.
- Publish the monograph.
- Open the monograph’s public catalog page.
- The References heading is displayed even though there are no references.
Expected result
If no references have been provided, the References section and its heading should not be displayed.
Actual result
The References heading is displayed, but the section itself is empty.
Application version
OMP 3.5.0-5
Additional information
This is only a minor display issue and does not affect the publication workflow. I noticed it while testing OMP 3.5 and thought I would report it because it appears to be the same issue that has already been fixed in OJS.
Thank you!