[OMP 3.5.0-5] Merging a user with masthead history causes Editorial History HTTP 500 and reassigns historical service to the target user

Hello!

Sorry for posting several issues lately. I am currently testing OMP 3.5 systematically, and I thought that if I can reproduce and document these problems clearly, the reports may be useful for you when there is time to address them — even in cases where I can find a workaround that allows us to keep the system usable for our editors.

Describe the issue or problem

I found two related problems when merging a user who has an ended masthead role / Editorial History entry.

The issue is reproducible both:

  • on an upgraded OMP 3.5.0-5 staging installation; and

  • on a clean local OMP 3.5.0-5 installation.

Immediately after merging the historical editor account into another user, the public Editorial History page returns HTTP 500.

The page starts working again after another masthead-related user setting is modified and saved.

After the page becomes available again, the historical editorial service of the original user is displayed under the target user’s name, i.e. the account into which the original editor was merged, provided that the transferred role is still set to “Appear on masthead” for the target user.

Disabling Appear on masthead for that role prevents the incorrect historical entry from being displayed publicly, so this can serve as a partial workaround. However, the transferred role assignment itself still remains associated with the target user. This results in historically incorrect information being displayed unless the masthead visibility is manually disabled after the merge.

Steps to reproduce

  1. Create or use User A.

  2. Give User A an editorial role that appears on the masthead.

  3. Ensure the role has a start date.

  4. End/remove the role so that User A appears on the public Editorial History page.

  5. Create or use a different User B.

  6. Merge User A into User B.

  7. Immediately open:

/about/editorialHistory

Actual result – problem 1

The Editorial History page returns:

HTTP 500 Internal Server Error

This was reproduced on both the upgraded staging installation and a clean OMP 3.5.0-5 localhost installation.

Additional reproduction of the cache-related behaviour

While the Editorial History page is returning HTTP 500:

  1. Edit a different user’s masthead settings for an editorial role that is included in Editorial Masthead / Editorial History (for example, change the “Appear on masthead” setting for a Press Editor role).

  2. Save the change.

  3. Reload the Editorial History page.

The Editorial History page immediately becomes accessible again.

This suggests that the user merge does not invalidate the Editorial Masthead / Editorial History cache correctly, while a normal masthead-setting update does.

Actual result – problem 2

After the Editorial History page becomes accessible again, User A’s historical editorial role is displayed under User B’s name.

For example:

Before merge:

User A – Editor – 2018–2022

After merging User A into User B:

User B – Editor – 2018–2022

If Appear on masthead is subsequently disabled for this transferred assignment on User B, the historical entry disappears from Editorial History.

Expected behaviour

The merge should also invalidate any relevant Editorial Masthead / Editorial History cache so that the page does not temporarily return HTTP 500.

This is particularly important because an administrator may need to remove a user account in response to an account-deletion or data-protection request. In the current interface, merging the user into another account is the available mechanism for removing the original account. In such a case, it is problematic if the former user’s historical editorial role is transferred to and publicly displayed under another person’s account instead of being removed or otherwise handled independently of the deleted user account.

Application

OMP 3.5.0-5

Environments tested

Environment 1

  • OMP upgraded from 3.4.0-9 to 3.5.0-5

  • Reproduced

Environment 2

  • Clean local OMP 3.5.0-5 installation

  • Reproduced

Additional information

The behaviour appears to have two separate but related components:

  1. Possible cache invalidation issue:
    Immediately after the merge, the Editorial History page returns HTTP 500. Performing another masthead-related update causes the page to work again immediately.

  2. Historical attribution issue:
    The ended masthead assignment is transferred to the merge target user, preserving the historical dates but displaying them under the wrong person’s name.

If I can help with any further testing or provide additional information, please let me know.

Kind regards,
Tiffany

Hi @flptiffany,

Thanks for this detailed report of this issue. I’m flagging this for our QA lead to look into. If you have any PHP error log messages from aroudn the time you hit the 500 message that may provide more clues as well.

Best,

Roger
PKP Team

Thanks again @flptiffany . I believe we have some upcoming changes that should fix this. I was not able to reproduce the 500 error with our current fixes in place.

There are the improved masthead changes : Improve control over masthead presentation · Issue #13370 · pkp/pkp-lib · GitHub

There was another fix with masthead and users who have been disabled : [Disabled User] | Reader Workflow Section - Editorial Masthead Page, When a user has been disabled and should appear on the masthead it is throwing a 500 error page · Issue #13387 · pkp/pkp-lib · GitHub

I’m not sure about what the expectations are for the user who absorbed the Editorial masthead user. I can see that User B is now displayed on the editorial history.

Here is an example where i merged user A who was to be on the Editorial History page with User B who was not on the editorial history page. I created a ticket to investigate the expectation here. My guess is if you merge A into B then B will be correctly displayed here.

Follow up. I have closed the investigation ticket as it was deemed to be working correctly. When you merge user A with user B they will absorb all attributes of the user including the masthead state. This should be now resolved in the upcoming 3.5.0-6 release.