[OJS 3.x] Problem uploading files in copyediting stage for 1 submission

Hello all, @asmecher, @NateWr , @ctgraham ,

I’m having problems with a single submission, being unable to upload files in the copyediting stage. The file upload modal only shows “Loading” message, but nothing appears. This submission was published in an issue, but it wasn’t really done. We publish the metadata page as soon as we have a few articles approved for the next issue to provide the articles a quicker visibility and trying to force faster submission and review. So, the copyediting, citations and references checking and layout have not been completed yet.

Now, OJS prevents us from changing a published article, so we need to unpublish, make changes and publish again, which has been working so far, except for this submission.

When tailing the error log, this is what is presented:

[Wed Aug 11 16:40:02.829989 2021] [php7:warn] [pid 753223] [client 192.168.0.240:34404] PHP Warning:  Declaration of ManageFinalDraftFilesForm::execute($stageSubmissionFiles, $fileStage = NULL) should be compatible with ManageSubmissionFilesForm::execute($stageSubmissionFiles = NULL, $fileStage = NULL, ...$functionArgs) in /var/www/revista.ibict.br/lib/pkp/controllers/grid/files/final/form/ManageFinalDraftFilesForm.inc.php on line 39, referer: http://revista.ibict.br/ciinf/workflow/index/5049/4
[Wed Aug 11 16:40:02.897678 2021] [php7:error] [pid 753223] [client 192.168.0.240:34404] PHP Fatal error:  Uncaught Error: Call to a member function getAssocId() on null in /var/www/revista.ibict.br/lib/pkp/controllers/grid/files/SubmissionFilesCategoryGridDataProvider.inc.php:131\nStack trace:\n#0 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(402): SubmissionFilesCategoryGridDataProvider->loadCategoryData()\n#1 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(124): CategoryGridHandler->loadCategoryData()\n#2 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(473): CategoryGridHandler->getGridCategoryDataElements()\n#3 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(453): CategoryGridHandler->_renderCategoryInternally()\n#4 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(276): CategoryGridHandler->_renderCategoriesInternally()\n#5 /var/www/revista.ibict.br/lib/pkp/classes/controllers/grid/GridHandler.inc.php(643): CategoryGridHandl in /var/www/revista.ibict.br/lib/pkp/controllers/grid/files/SubmissionFilesCategoryGridDataProvider.inc.php on line 131, referer: http://revista.ibict.br/ciinf/workflow/index/5049/4

Any ideas?

Hi @ramon,

Are you able to provide the specific version number, please? You indicated 3.x, but it would be helpful to know the specific version number you’re working in.

-Roger
PKP Team

Hello all, @rcgillis ,

Thanks for the quick reply and sorry to respond so late.
We are using OJS 3.3.0.7
And this is happening on a single submission. Other are fine, so far.

Dear all,

We also have a similar problem using OJS 3.3.0.8.
@ramon , have you found any solution?

Best regards,

@eddoff

Dear all again,

The problem arise at the copyediting tab when try to click on “Upload/select files” either under the headline “draft files” or under “Copyedited” headline.

The pop-up window appears, but it says only “loading” as described by @ramon. Our article has not been published.

This is my error log message:

[Wed Feb 02 09:13:15.599670 2022] [php7:warn] [pid 27860] [client xx.xx.xx.xx:4158] PHP Warning:  Declaration of ManageCopyeditFilesForm::execute($stageSubmissionFiles, $fileStage = NULL) should be compatible with ManageSubmissionFilesForm::execute($stageSubmissionFiles = NULL, $fileStage = NULL, ...$functionArgs) in /var/www/html/journal/lib/pkp/controllers/grid/files/copyedit/form/ManageCopyeditFilesForm.inc.php on line 18, referer: https://mydomain.com/workflow/index/3385/4
[Wed Feb 02 09:13:15.846901 2022] [php7:error] [pid 27860] [client xx.xx.xx.xx:4158] PHP Fatal error:  Uncaught Error: Call to a member function getAssocId() on null in /var/www/html/journal/lib/pkp/controllers/grid/files/SubmissionFilesCategoryGridDataProvider.inc.php:131\nStack trace:\n#0 /var/www/html/journal/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(402): SubmissionFilesCategoryGridDataProvider->loadCategoryData(Object(Request), 4, Array)\n#1 /var/www/html/journal/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(124): CategoryGridHandler->loadCategoryData(Object(Request), 4, Array)\n#2 /var/www/html/journal/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(473): CategoryGridHandler->getGridCategoryDataElements(Object(Request), 4)\n#3 /var/www/html/journal/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(453): CategoryGridHandler->_renderCategoryInternally(Object(Request), Object(SelectableSubmissionFileListCategoryGridRow))\n#4 /var/www/html/journal/lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php(276): CategoryGridHandler->_renderCategoriesIntern in /var/www/html/journal/lib/pkp/controllers/grid/files/SubmissionFilesCategoryGridDataProvider.inc.php on line 131, referer: https://mydomain.com/workflow/index/xxxx/4

There is also problems in going into the Activity log. Then the following error appears in the log:


[Wed Feb 02 09:27:49.555003 2022] [php7:error] [pid 27657] [client 10.243.0.73:4668] PHP Fatal error:  Uncaught Error: Call to a member function getAssocId() on null in /var/www/html/journal/lib/pkp/classes/services/PKPSubmissionFileService.inc.php:774\nStack trace:\n#0 /var/www/html/journal/lib/pkp/controllers/grid/eventLog/EventLogGridRow.inc.php(79): PKP\\Services\\PKPSubmissionFileService->getWorkflowStageId(Object(SubmissionFile))\n#1 /var/www/html/journal/lib/pkp/classes/controllers/grid/GridHandler.inc.php(1066): EventLogGridRow->initialize(Object(Request))\n#2 /var/www/html/journal/lib/pkp/classes/controllers/grid/GridHandler.inc.php(983): GridHandler->_getInitializedRowInstance(Object(Request), 1, Object(SubmissionEventLogEntry))\n#3 /var/www/html/journal/lib/pkp/classes/controllers/grid/GridHandler.inc.php(1031): GridHandler->renderRowsInternally(Object(Request), Array)\n#4 /var/www/html/journal/lib/pkp/classes/controllers/grid/GridHandler.inc.php(921): GridHandler->renderGridBodyPartsInternally(Object(Request))\n#5 /var/www/html/journal/lib/pkp/classes/controllers/grid/GridHandler.inc.php(643): GridHandler-> in /var/www/html/journal/lib/pkp/classes/services/PKPSubmissionFileService.inc.php on line 774, referer: https://mydomain.com/workflow/index/xxxx/4

Thank you for your help!

@eddoff

Hello @eddoff ,

Unfortunately, no solution so far.
Since it was a single submission (and I don’t remember now which one to check), we probably handled it manually or created a new submission to replace the problematic one.

Hello all,

We are also affected by the problem of not being able to upload data to the “Draft Files” and “Copyedited” fields in the editing phase (see Unable to Upload/Select Files from Copyediting Stage (fix ineffective)).

The current OJS upgrade 3.3.0.9 addresses the problem. Here is the fix:

I did not run the whole upgrade, but only updated the SubmissionFilesCategoryGridDataProvider.inc.php file.

Afterwards, the problem unfortunately still exists.

Screenshot 2022-03-15 084010

Curiously, no error message appears in the PHP Error Log, only a warning:

[15-Mar-2022 09:00:12 Europe/Berlin] PHP Warning:  Declaration of ManageFinalDraftFilesForm::execute($stageSubmissionFiles, $fileStage = NULL) should be compatible with ManageSubmissionFilesForm::execute($stageSubmissionFiles = NULL, $fileStage = NULL, ...$functionArgs) in /home/suburban/public_html/sys/lib/pkp/controllers/grid/files/final/form/ManageFinalDraftFilesForm.inc.php on line 39
[15-Mar-2022 09:00:12 Europe/Berlin] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/suburban/public_html/sys/lib/pkp/controllers/grid/files/final/form/ManageFinalDraftFilesForm.inc.php:18) in /home/suburban/public_html/sys/lib/pkp/classes/core/PKPRouter.inc.php on line 412

Do I need to run the whole upgrade to fix the error?

Short addition: The full upgrade to version 3.3.0.10 has fixed the bug.

2 Likes

This topic was automatically closed after 10 days. New replies are no longer allowed.