Hi,
We are working on OJS 3.2.1-0 from a tarball using PHP 7.2.
When an editor modifies notes on a reviewer, the following PHP Notice appears in the OJS error_log:
PHP Notice: Undefined variable: user in /var/www/html/lib/pkp/controllers/grid/users/reviewer/form/ReviewerGossipForm.inc.php on line 70
The code on github pkp-lib master (lib/pkp/controllers/grid/users/reviewer/form/ReviewerGossipForm.inc.php
\ReviewerGossipForm::execute
):
function execute(...$functionArgs) {
$this->_user->setGossip($this->getData('gossip'));
$userDao = DAORegistry::getDAO('UserDAO'); /* @var $userDao UserDAO */
$userDao->updateObject($this->_user);
parent::execute(...$functionArgs);
return $user;
}
$user
is undefined.
Should this be returning $this->_user
, $this
, anything at all?
Thanks,