I made the changes and then tested the review process. For the reviewer step 2 looks OK but when clicking continue Step 3 is blank. I went back and removed the changes and still same thing.
I only changed the code in the areas indicated and have gone back to check if I missed anything but I must have.
The should fix work. We have had it in our production server with 60 journals for a week now. And I know at least one other journal that had the same problem and fixed it with doing the changes there. That is already merged to the master branch so it will be available in the next OJS release.
What are you using to make modifications to the file? If you are using something like Notepad, that could create problems when you edit the OJS files.
What editor do you use to edit the file? The only thing I can think of is that the file is corrupted someway when you save the changes. What error do you get in php error log after the change when you go to that stage?
The code changes are in the execute function and that function is only called when you move from stage 3 to stage 4.
The other option is of course that you wait for a few weeks, the change is now in master branch and will be available in the next OJS release. You can then just upgrade to that version when it is released.
I copied thew file in the last link you sent to Word. Then I checked it against the old file. The changes were verified. Then I uploaded the new file to the server.
In the first iteration I made the changes directly in cpanel and verified them.
Is it possible that something is going on with the way the review form is specified or handled. As you can see from previous posts Step 3 works fine. I wonder if the code above the change is affecting this when the new bracket at line 194 is inserted.
I am a little hesitant to upgrade right now as the process from 2.4.8 was tedious and time consuming. Also from the posts there seem to be a lot of issues with 3.1.1 upgrades.
Although upgrades can be difficult sometimes, there are always a lot of bugs that get fixed. Wait for the 3.1.1.1 release, it will probably fix most of the problems you have seen here with 3.1.1 upgrades.
The problem is probably that you use Word to edit the file. Try downloading a program like Notepad++ and edit the file with that. Word could add something there that breaks the file. I have not used cpanel myself to edit files so do not know if editing php files with the file manager there has problems.
OK I used notepad to save the file in your link and uploaded it to the server. You were right that Word must have inserted something. Important lesson learned!
Now Step 3 works and the system sends an email to the editor after the review has been completed. The issue now is that it is not the Review Complete email but a notification (See Below)
Is there something that needs to be changed to have the system send the Review Complete email. That email is in my list of emails in the Workflow.
Here is the one that the system sent in earlier versions. Guess it is left over. It would be nice to have it back but at least we are now getting notified when a reviewer has done something. We can live with that for now.
Yeah, I think that is an old template left behind. I do not think it has been used since 2.4.8 ojs/ReviewerAction.inc.php at ojs-stable-2_4_8 · pkp/ojs · GitHub at least I do not remember seeing that back in 3.0.2 or 3.1.0 and could not find it in the code either.
In any case, if you think that the current notification is not as good as it could be, you can always add a feature request here at the forum.
Yes It seems to be a leftover. However the notifications that appear to be related to any activity on a submission are good enough ticklers that something has been done. Not specific on what but at least I know to check.
Maybe in the future I can find out where these are structured so they can be modified.