fixAuthorGroup function in the update

ajnyga · January 18, 2018, 8:24pm

I am looking at the upgrade function here:

pkp/ojs/blob/ojs-stable-3_1_0/classes/install/Upgrade.inc.php#L1966


	 * @return boolean
	 */
	function fixAuthorGroup() {
		$userGroupDao = DAORegistry::getDAO('UserGroupDAO');
		$result = $userGroupDao->retrieve(
			'SELECT a.author_id, s.context_id FROM authors a JOIN submissions s ON (a.submission_id = s.submission_id) JOIN user_groups g ON (a.user_group_id = g.user_group_id) WHERE g.context_id <> s.context_id'
		);
		while (!$result->EOF) {
			$row = $result->GetRowAssoc(false);
			$authorGroup = $userGroupDao->getDefaultByRoleId($row['context_id'], ROLE_ID_AUTHOR);
			if ($authorGroup) $userGroupDao->update('UPDATE authors SET user_group_id = ? WHERE author_id = ?', array((int) $authorGroup->getId(), $row['author_id']));
			$result->MoveNext();
		}
		$result->Close();
		return true;
	}

	/**
	 * For 3.0.0 - 3.0.2 upgrade: first part of the fix for the migrated reviewer files.
	 * The files are renamed and moved from 'review' to 'review/attachment' folder.
	 * @return boolean

The sql there does not make sense to me. Should there be a WHERE clause there? I think it is now looping through the result and each time updating the user_group_id column for the whole authors table?

asmecher · January 18, 2018, 9:33pm

Hi @ajnyga,

Hmm, absolutely right. I’ve filed this at Author `user_group_id` upgrade `UPDATE` is broken · Issue #3289 · pkp/pkp-lib · GitHub. But I suspect that this column is dead weight – I’ve suggested an audit and possible removal in the filed issue.

Regards,
Alec Smecher
Public Knowledge Project Team

ajnyga · January 19, 2018, 7:10am

Thanks @asmecher

To be on the safe side, I changed that line to:
if ($authorGroup) $userGroupDao->update('UPDATE authors SET user_group_id = ? WHERE author_id = ?', array((int) $authorGroup->getId(), $row['author_id']));

That is probably how it was intended. The result was that the function finishes almost instantly whereas the old query took for hours.

asmecher · January 22, 2018, 9:50pm

Hi @ajnyga,

Thanks – your proposed fix is correct. I’ve committed it at the github entry above (both ojs-stable-3_1_0 and master). Glad to hear it also improves performance.

Regards,
Alec Smecher
Public Knowledge Project Team

ajnyga · January 23, 2018, 7:12am

Thanks @asmecher, I added one more comment to the issue, because I think that potentially journals upgrading with the version available at the PKP website will loose some metadata which can not be fixed later. I could be wrong.