Errors with Plugins OJS 3.3 - Failed Ajax request

njamar · August 9, 2022, 2:53pm

Hello,

We are on ojs 3.3-10. We recently updated php to php 8.0. When I want to setup settings of some plugins, I got this error Failed Ajax request or invalid JSON

In the error logs, it gave me this:

Declaration of WebFeedSettingsForm::fetch($request) must be compatible with Form::fetch($request, $template = null, $display = false)
Declaration of AddThisSettingsForm::fetch($request) must be compatible with Form::fetch($request, $template = null, $display = false)
Declaration of PiwikSettingsForm::fetch($request) must be compatible with Form::fetch($request, $template = null, $display = false)

As you can see, the error is not relative to one plugin in particular.

I have found this Web Feed Plugin OJS 3.3.0-10 LTS in the forum but I don’t understand how to apply the fix. Can you help me ?

Thanks.

jnugent · August 9, 2022, 6:35pm

Hi @njamar

You can either downgrade PHP to PHP 7.4, or you can upgrade OJS to 3.3.0.11 which contains a fix for the WebFeed plugin:

github.com

pkp/ojs/blob/3_3_0-11/plugins/generic/webFeed/WebFeedSettingsForm.inc.php#L72


      
          		if ($this->getData('displayItems') == 'recent') {
          			$this->addCheck(new FormValidator($this, 'recentItems', 'required', 'plugins.generic.webfeed.settings.recentItemsRequired'));
          		}
          
          
	}
          
          
	/**
          	 * Fetch the form.
          	 * @copydoc Form::fetch()
          	 */
          	function fetch($request, $template = null, $display = false) {
          		$templateMgr = TemplateManager::getManager($request);
          		$templateMgr->assign('pluginName', $this->_plugin->getName());
          		return parent::fetch($request, $template, $display);
          	}
          
          
	/**
          	 * @copydoc Form::execute()
          	 */
          	function execute(...$functionArgs) {
          		$plugin = $this->_plugin;

But the AddThis and PiWik plugins will need to be disabled as they will not work with PHP 8. The AddThis plugin is already fixed for OJS 3.4.

Best
Jason