Dears,
I have error in my journal when the reviewer try to accept the review, the system keep loading in same potion after click accept button and review accepting notice is not appear for Editor.
issue attached in gif
More details from server log
#0 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/ReviewerAction.php(158): PKP\mail\mailables\ReviewConfirm->recipients()
#1 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/ReviewerAction.php(68): PKP\submission\reviewer\ReviewerAction->getResponseEmail()
#2 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/form/PKPReviewerReviewStep1Form.php(145): PKP\submission\reviewer\ReviewerAction->confirmReview()
#3 /home/eastrrtf/public_html/lib/pkp/pages/reviewer/PKPReviewerHandler.php(141): PKP\submission\reviewer\form\PKPReviewerReviewStep1Form->execute()
#4 [internal function]: PKP\pages\reviewer\PKPReviewerHandler->saveStep()
#5 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPRouter.php(334): call_user_func()
#6 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPPageRouter.php(277): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()
#7 /home/eastrrtf/public_html/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPPageRouter->route()
#8 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPApplication.php(388): PKP\core\Dispatcher->dispatch()
#9 /home/eastrrtf/public_html/index.php(21): PKP\core\PKPApplication->execute()
#10 {main}
thrown in /home/eastrrtf/public_html/lib/pkp/classes/mail/traits/Recipient.php on line 55
You’ve included the stack trace, but the actual error message will appear in the line or two above what you’ve posted. Can you post the error message?
Regards,
Alec Smecher
Public Knowledge Project Team
Thank you sir for your mention and sorry for missing the error.
here the error , I think you mean this
[25-Apr-2025 15:48:29 Asia/Muscat] PHP Fatal error: Uncaught InvalidArgumentException: Expecting an array consisting of instances of PKP\identity\Identity to be passed to PKP\mail\mailables\ReviewConfirm::recipients in /home/eastrrtf/public_html/lib/pkp/classes/mail/traits/Recipient.php:55
Stack trace:
#0 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/ReviewerAction.php(158): PKP\mail\mailables\ReviewConfirm->recipients()
#1 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/ReviewerAction.php(68): PKP\submission\reviewer\ReviewerAction->getResponseEmail()
#2 /home/eastrrtf/public_html/lib/pkp/classes/submission/reviewer/form/PKPReviewerReviewStep1Form.php(145): PKP\submission\reviewer\ReviewerAction->confirmReview()
#3 /home/eastrrtf/public_html/lib/pkp/pages/reviewer/PKPReviewerHandler.php(141): PKP\submission\reviewer\form\PKPReviewerReviewStep1Form->execute()
#4 [internal function]: PKP\pages\reviewer\PKPReviewerHandler->saveStep()
#5 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPRouter.php(334): call_user_func()
#6 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPPageRouter.php(277): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()
#7 /home/eastrrtf/public_html/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPPageRouter->route()
#8 /home/eastrrtf/public_html/lib/pkp/classes/core/PKPApplication.php(388): PKP\core\Dispatcher->dispatch()
#9 /home/eastrrtf/public_html/index.php(21): PKP\core\PKPApplication->execute()
#10 {main}
thrown in /home/eastrrtf/public_html/lib/pkp/classes/mail/traits/Recipient.php on line 55
I suspect you have a disabled user who is active in the submission’s workflow. Because the account is disabled, it’s not being fetched as expected, causing an error – but it also shouldn’t be included in email recipient list, as it’s disabled, so the right move is to skip it. Could you try applying this patch in the lib/pkp subdirectory?
diff --git a/classes/submission/reviewer/ReviewerAction.php b/classes/submission/reviewer/ReviewerAction.php
index 9c31e640de..fc2f55d037 100644
--- a/classes/submission/reviewer/ReviewerAction.php
+++ b/classes/submission/reviewer/ReviewerAction.php
@@ -140,11 +140,12 @@ class ReviewerAction
$recipients = [];
while ($stageAssignment = $stageAssignments->next()) {
$userGroup = Repo::userGroup()->get($stageAssignment->getUserGroupId());
- if (!in_array($userGroup->getRoleId(), [Role::ROLE_ID_MANAGER, Role::ROLE_ID_SUB_EDITOR])) {
+ $user = Repo::user()->get($stageAssignment->getUserId());
+ if (!$user || in_array($userGroup->getRoleId(), [Role::ROLE_ID_MANAGER, Role::ROLE_ID_SUB_EDITOR])) {
continue;
}
- $recipients[] = Repo::user()->get($stageAssignment->getUserId());
+ $recipients[] = $user;
}
// Create dummy user if no one assigned
Please report back if it works; if so, I’ll commit it for the next release.
Regards,
Alec Smecher
Public Knowledge Project Team
This topic was automatically closed after 9 days. New replies are no longer allowed.